Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Ales Ledvinka
quot; Sent: Monday, January 7, 2013 12:31:19 PM Subject: Re: [Ipmitool-devel] code analysis On Mon, Jan 7, 2013 at 12:25 PM, Ales Ledvinka wrote: [...] >> > Then it's about effort to generate the report, >> > effort to check the reported item >> > whether it's

Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Zdenek Styblik
On Mon, Jan 7, 2013 at 12:25 PM, Ales Ledvinka wrote: [...] >> > Then it's about effort to generate the report, >> > effort to check the reported item >> > whether it's security issue or not and effort to fix it. These are >> > not the same thing. >> >> Right. And if you want to do it all behind t

Re: [Ipmitool-devel] code analysis

2013-01-07 Thread Ales Ledvinka
- Original Message - > From: "Zdenek Styblik" > To: "Ales Ledvinka" > Cc: "ipmitool-devel" > Sent: Saturday, January 5, 2013 1:23:03 PM > Subject: Re: [Ipmitool-devel] code analysis > > On Fri, Jan 4, 2013 at 8:10 PM, Ales Ledvinka

Re: [Ipmitool-devel] code analysis

2013-01-05 Thread Zdenek Styblik
On Fri, Jan 4, 2013 at 8:10 PM, Ales Ledvinka wrote: [...] > Per issue, file or defect type group? > It's hard to say in a general way. Sometimes one is better than another and sometimes it's better to edit hell out of .c file. [...] >> > Reasonable minimal fix. If further question remain then a

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Ales Ledvinka
- Original Message - > From: "Zdenek Styblik" > To: "Ales Ledvinka" > Cc: "Jim Mank" , "ipmitool-devel" > > Sent: Friday, January 4, 2013 6:17:49 PM > Subject: Re: [Ipmitool-devel] code analysis > > On Fri, Jan 4, 20

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Jim Mankovich
Z & Ales, I would agree that there should be tickets for the issues. In fact, there may already be tickets for some of the issues found by the analysis. Not having any info yet on what the code analysis shows, its pretty hard to have any feeling for what, if anything, might really need to be fi

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Zdenek Styblik
On Fri, Jan 4, 2013 at 5:48 PM, Ales Ledvinka wrote: > >> I don't know how much I can help with the >> fixing, but if I have >> time I'll do what I can. > > You are welcome. Send me mail with the list of files you are going to touch. I hope you two will find a better way than this. Like creating

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Ales Ledvinka
> I don't know how much I can help with the > fixing, but if I have > time I'll do what I can. You are welcome. Send me mail with the list of files you are going to touch. > I'm curious as to how will you determine which issues to fix? Reasonable minimal fix. If further question remain then add

Re: [Ipmitool-devel] code analysis

2013-01-04 Thread Jim Mankovich
Ales, I am interested in understanding what kind of issues show up in the report, so please send it my way. I'm not familiar with "rawhide code analysis", so will I be able to understand the report? I don't know how much I can help with the fixing, but if I have time I'll do what I can. I'

[Ipmitool-devel] code analysis

2013-01-04 Thread Ales Ledvinka
Hello, I just joined the team. I have here the ipmitool Fedora 19 rawhide code analysis report. The report is for 1.8.12 with two picked cvs patches so it's not cvs but close to fix there. I did not review the report for security issues, false positives or severity. If you are a sf ipmitool deve