Re: [ipxe-devel] [PATCH 1/3] scsi: Improve sense code parsing

2014-06-02 Thread Michael Brown
On 30/05/14 08:18, Hannes Reinecke wrote: The SCSI sense code comes in two flavours, 'fixed' and 'descriptor'. Each of which have the interesting portions like additonal sense code etc at different locations. So instead of blindly copying out some bytes we should parse the sense code buffer and m

Re: [ipxe-devel] [PATCH 2/3] igbvf: Assign random MAC address if none is set

2014-06-02 Thread Michael Brown
On 02/06/14 07:02, Hannes Reinecke wrote: On 06/02/2014 12:36 AM, Michael Brown wrote: +if ( is_valid_ether_addr( netdev->hw_addr )) { +memcpy ( adapter->hw.mac.addr, netdev->hw_addr, ETH_ALEN); +} + mac->ops.init_hw ( hw ); if ( is_valid_ether_addr(adapter->hw.mac.

Re: [ipxe-devel] [PATCH 3/3] Set correct 'origin' field in iBFT structure

2014-06-02 Thread Michael Brown
On 02/06/14 07:08, Hannes Reinecke wrote: This is interesting. The test as you've written it will detect if DHCP was ever performed on the network device. If an address was obtained via DHCP and then overridden with a static address using "set net0/ip x.x.x.x" then the DHCP settings block will

Re: [ipxe-devel] DHCP_SERVER_IDENTIFIER is not included in the Proxy DHCP

2014-06-02 Thread Michael Brown
On 02/06/14 08:51, Wissam Shoukair wrote: And if the server doesn't include this option (54) in his ProxyDHCP Offer (real case that I'm having) then my iPXE stack will see it as IP of zeros and therefore it will ignore it (because I don't have an IP yet - didn't get any DHCP Offer from the reg

Re: [ipxe-devel] Proxy DHCP server reply port

2014-06-02 Thread Gene Cumm
On Mon, Jun 2, 2014 at 5:42 AM, Wissam Shoukair wrote: > Hi, > When we send ProxyDHCP Request to port 4011 (PXE_PORT), the ProxyDHCP ACK > that we get in response it’s from port 67 (BOOTPS_PORT), and we see that in > iPXE stack drops this packet because the server’s port is not 4011. > > I don’t

[ipxe-devel] Proxy DHCP server reply port

2014-06-02 Thread Wissam Shoukair
Hi, When we send ProxyDHCP Request to port 4011 (PXE_PORT), the ProxyDHCP ACK that we get in response it's from port 67 (BOOTPS_PORT), and we see that in iPXE stack drops this packet because the server's port is not 4011. I don't think that the server's port which the packet came from should be

Re: [ipxe-devel] DHCP_SERVER_IDENTIFIER is not included in the Proxy DHCP

2014-06-02 Thread Wissam Shoukair
Thanks Michael. And if the server doesn't include this option (54) in his ProxyDHCP Offer (real case that I'm having) then my iPXE stack will see it as IP of zeros and therefore it will ignore it (because I don't have an IP yet - didn't get any DHCP Offer from the regular DHCP). Is this the exp