Re: [ipxe-devel] [ipxe/ipxe] Wrong UUID on (some) Dell systems (#30)

2019-02-08 Thread Geert Stappers
FWIW: I think it would have helped if it were several commits. The four year old commit does much more then ``` if ( uuid.canonical.a == 0x4c4c4544 ) { uuid_mangle ( &uuid ); } ``` What the extra changes are, is now lost in the large commit ... -- You are receivin

Re: [ipxe-devel] [ipxe/ipxe] [util] Fix a potential problem in ROM.pm. (#89)

2019-02-08 Thread dbankov-vmware
Thanks for looking at this. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/89#issuecomment-461743141___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://list

Re: [ipxe-devel] [ipxe/ipxe] [dhcp/ipv4] Support for DHCP option 121: Classless static route option (#67)

2019-02-08 Thread Geert Stappers
The patch @hazelesque talks about became #78 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/67#issuecomment-461741729___ ipxe-devel mailing list

Re: [ipxe-devel] [ipxe/ipxe] [util] Fix a potential problem in ROM.pm. (#89)

2019-02-08 Thread dbankov-vmware
Closed #89. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/89#event-2126577548___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/lis

Re: [ipxe-devel] [ipxe/ipxe] [util] Fix a potential problem in ROM.pm. (#89)

2019-02-08 Thread Geert Stappers
> > The Logical Defined-Or operator ( // ) was introduced to Perl 5.10 released > > on December 18th, 2007. > > The problem is observed during the script execution which happens as part of > the build process. > The result is a broken (make all) build on a build machine with perl 5.8.8. > I don'

Re: [ipxe-devel] [ipxe/ipxe] [build] Do not use WORKAROUND_CFLAGS with HOST_CC when cross-compiling (#80)

2019-02-08 Thread Martin Habets
Acked-by: Martin Habets -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/80#issuecomment-461737699___ ipxe-devel mailing list ipxe-devel@lists.ipx

Re: [ipxe-devel] [ipxe/ipxe] gensdsk: fix default target (#76)

2019-02-08 Thread Geert Stappers
In twelve days becomes this pull request six months old. I do hope that this PR gets a real judgement before that date. Either by a merge or a reject. Leaving it hanging/dangling/rotting here has no use ... -- You are receiving this because you are subscribed to this thread. Reply to this emai

Re: [ipxe-devel] [ipxe/ipxe] [build] handle R_X86_64_PLT32 from binutils 2.31 (#77)

2019-02-08 Thread Christian Hesse
Closed #77. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/77#event-2126511716___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/lis

Re: [ipxe-devel] [ipxe/ipxe] [build] handle R_X86_64_PLT32 from binutils 2.31 (#77)

2019-02-08 Thread Christian Hesse
Close. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/77#issuecomment-461732980___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/l

Re: [ipxe-devel] [ipxe/ipxe] [build] handle R_X86_64_PLT32 from binutils 2.31 (#77)

2019-02-08 Thread Geert Stappers
Patch was applied three months ago. I wish I could close this pull request. Closing this PR will prevent further drain on resources spent the list of pull requests. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/

Re: [ipxe-devel] [ipxe/ipxe] [util] Fix a potential problem in ROM.pm. (#89)

2019-02-08 Thread dbankov-vmware
> The proposed patch mentions a _runtime_ error. I'm sorry this is not phrased correctly (I'll edit the description). The problem is observed during the script execution which happens as part of the build process. The result is a broken (make all) build on a build machine with perl 5.8.8. I do