Re: [ipxe-devel] [ipxe/ipxe] [tls] Add support for fragmented tls handshake packets (#116)

2022-04-12 Thread Christian Nilsson via ipxe-devel
> Note that there's also > https://github.com/chschenk/ipxe/tree/feature/tls_fragmentation_buildoption > which add's a build option. By making this code optional and disable that > build option by default it at least wouldn't break anything. Regarding > security concerns: granted. But we're tal

Re: [ipxe-devel] [ipxe/ipxe] [tls] Add support for fragmented tls handshake packets (#116)

2022-04-12 Thread Christian Nilsson via ipxe-devel
Time needed to verify correctness of this patch is one possible issue, maybe this could be lessened with proper tests, or at least something that can be used to verify the issue. But this is critical code that and we must be absolute certain does not introduce any new security issues. -- Repl

Re: [ipxe-devel] [ipxe/ipxe] QRcode (#102)

2022-03-08 Thread Christian Nilsson via ipxe-devel
@steverweber ASCII is 7bit, = max char 127, Extended ASCII is not really defined here, BIOS mode is often CP437 but no guarantees, iPXE just outputs puts bytes on the output buffer, then BIOS/EFI is responsible for how that is displayed. (From what I understood EFI is always UCS-2) -- Reply to

Re: [ipxe-devel] [ipxe/ipxe] QRcode (#102)

2022-02-11 Thread Christian Nilsson via ipxe-devel
This is a cool feature! For any chance to merge it needs to only have intended changes and nothing else, and clean commits. This means that it needs to be rebased and cleaned up to reviewable commits. Also depending on or including external code will not be an option. License is one concern. May

Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)

2022-02-11 Thread Christian Nilsson via ipxe-devel
Is this still an issue in current master? -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-1036405097 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-deve

Re: [ipxe-devel] [ipxe/ipxe] Add ability to build an RPM (#17)

2022-02-11 Thread Christian Nilsson via ipxe-devel
Closed #17. -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/17#event-6052531200 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.o

Re: [ipxe-devel] [ipxe/ipxe] Add ability to build an RPM (#17)

2022-02-11 Thread Christian Nilsson via ipxe-devel
If this was added to iPXE, how many other targets would be added for other packages? could this should be handled with scripts outside of iPXE? Based on the age I will be closing, but are happy to re-open if it is found that there is no better solution. And that it is rebased. -- Reply to this

Re: [ipxe-devel] [ipxe/ipxe] allow to build ISO image with EFI support (ipxe.eiso) (#50)

2021-04-24 Thread Christian Nilsson via ipxe-devel
I don't see a need for both, one iso with both should be fine? -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/50#issuecomment-826076226___ ipxe-devel mailing list ipx