Re: [ipxe-devel] [PATCH] [undi] Add stack segment logging

2016-06-09 Thread Ladi Prosek
On Thu, Jun 9, 2016 at 2:03 PM, Michael Brown wrote: > On 09/06/16 12:53, Ladi Prosek wrote: >> >> On Thu, Jun 9, 2016 at 1:05 PM, Michael Brown wrote: >>> >>> On 09/06/16 11:46, Ladi Prosek wrote: The UNDI ROM ID structure declares the minimum required stack segment size but the v

Re: [ipxe-devel] [PATCH] [undi] Add stack segment logging

2016-06-09 Thread Michael Brown
On 09/06/16 12:53, Ladi Prosek wrote: On Thu, Jun 9, 2016 at 1:05 PM, Michael Brown wrote: On 09/06/16 11:46, Ladi Prosek wrote: The UNDI ROM ID structure declares the minimum required stack segment size but the value is not used by iPXE. iPXE doesn't use any meaningful amount of real-mode s

Re: [ipxe-devel] [PATCH] [undi] Add stack segment logging

2016-06-09 Thread Ladi Prosek
On Thu, Jun 9, 2016 at 1:05 PM, Michael Brown wrote: > On 09/06/16 11:46, Ladi Prosek wrote: >> >> The UNDI ROM ID structure declares the minimum required stack segment >> size but the value is not used by iPXE. > > > iPXE doesn't use any meaningful amount of real-mode stack space outside of > its

Re: [ipxe-devel] [PATCH] [undi] Add stack segment logging

2016-06-09 Thread Michael Brown
On 09/06/16 11:46, Ladi Prosek wrote: The UNDI ROM ID structure declares the minimum required stack segment size but the value is not used by iPXE. iPXE doesn't use any meaningful amount of real-mode stack space outside of its own data segment. Without checking, I think we should be using le

[ipxe-devel] [PATCH] [undi] Add stack segment logging

2016-06-09 Thread Ladi Prosek
The UNDI ROM ID structure declares the minimum required stack segment size but the value is not used by iPXE. This commit adds stack-related logging to undirom_parse_pxeromid and undi_load to help with UNDI debugging. Signed-off-by: Ladi Prosek --- Ideally undi_load would fail if we don't have e