Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-04-04 Thread Michael Brown via ipxe-devel
On 14/03/2023 16:45, MohamedShah R wrote: Thanks for the quick response. I am new to the PXE source code and tried out the below changes  for the experimental testing in the netdev_close api and it works fine. Why can't we have a new api netdev_reopen() which does the same logic of netdev_close

Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-14 Thread MohamedShah R via ipxe-devel
Hi Michael, Thanks for the quick response. I am new to the PXE source code and tried out the below changes for the experimental testing in the netdev_close api and it works fine. Why can't we have a new api netdev_reopen() which does the same logic of netdev_close (except the code below) and call

Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-14 Thread Michael Brown via ipxe-devel
On 13/03/2023 21:31, Michael Brown via ipxe-devel wrote: There is what looks like a bug when using DHCP to change MTU: the change of MTU requires the interface to be closed and reopened, but closing the interface will cause the initiating DHCP transaction itself to be aborted. This probably re

Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-13 Thread Michael Brown via ipxe-devel
On 13/03/2023 17:48, MohamedShah R wrote: Hi Michael,  Thanks for your response. Below is the flow- I have seen in the execution- it hits the intf_close as part of netdev_close called from apply_netdev_settings,. https://github.com/ipxe/ipxe/blob/c4c03e5be867a9b7be4dc48fe6576deca1dce8d8/src/n

Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-13 Thread MohamedShah R via ipxe-devel
Hi Michael, Thanks for your response. Below is the flow- I have seen in the execution- it hits the intf_close as part of netdev_close called from apply_netdev_settings,. https://github.com/ipxe/ipxe/blob/c4c03e5be867a9b7be4dc48fe6576deca1dce8d8/src/net/netdevice.c#L868 . Please correct me if I am

Re: [ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-13 Thread Michael Brown via ipxe-devel
On 13/03/2023 03:16, MohamedShah R via ipxe-devel wrote: 1. If our device configures netdev->mtu as 1500  and netdev->max_pkt_len is 9128(above 9k). 2. If the DHCP server sends MTU size as 9K.    As per the code walk-through, I understand that this api "staticintapply_netdev_settings” g

[ipxe-devel] REG: Query on 9K MTU Testing flow

2023-03-12 Thread MohamedShah R via ipxe-devel
Hi, Scenario: 1. If our device configures netdev->mtu as 1500 and netdev->max_pkt_len is 9128(above 9k). 2. If the DHCP server sends MTU size as 9K.   As per the code walk-through, I understand that this api "static int apply_netdev_settings” get invoke and call the below part of