[Ironruby-core] Code Review: RegexGroupValues

2008-05-24 Thread Tomas Matousek
tfpt review "/shelveset:RegexGroupValues;REDMOND\tomat" Fixes group values - should be nil not an empty string on unsuccessful match. Tomas RegexGroupValues.diff Description: RegexGroupValues.diff ___ Ironruby-core mailing list Ironruby-core@rubyforg

[Ironruby-core] Code Review: RangeFixes

2008-05-24 Thread Tomas Matousek
tfpt review "/shelveset:RangeFixes;REDMOND\tomat" Refactors Array#[] and fixes MatchData#[] and Strign#to_i. Tomas RangeFixes.diff Description: RangeFixes.diff ___ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/lis

Re: [Ironruby-core] IronRuby r112 is out

2008-05-24 Thread John Lam (IRONRUBY)
Thanks for sending in your patch - we really do appreciate the effort that you put into it! We're just in a big time crunch before RailsConf so we're pretty well implementing anything that we need to in order to get Rails to run. Did we implement all of the methods in your patch? Perhaps you co

[Ironruby-core] Code Review: rails-6

2008-05-24 Thread John Lam (IRONRUBY)
tfpt review "/shelveset:rails-6;REDMOND\jflam" Two changes in this shelveset: - Implemented Kernel#loop - all specs pass. - Fixed implementation of IDictionaryOps#each* where we incorrectly used foreach() to iterate over a hash whose values could be mutated by code in the blocks. Thanks, -John