Looks good!
-Original Message-
From: Tomas Matousek
Sent: Monday, November 24, 2008 6:37 PM
To: IronRuby External Code Reviewers; DLR Code Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: NoComplexCall
tfpt review "/shelveset:NoComplexCall;REDMOND\tomat"
Outer DLR Change: Tw
Two misspellings should be noted -- the shelveset is actually named
NoComplexCalls and RubyMethodInfo.PramsArrayDelegateType needs another "a". :)
Looks good otherwise.
-Original Message-
From: Tomas Matousek
Sent: Monday, November 24, 2008 6:37 PM
To: IronRuby External Code Reviewers; D
tfpt review "/shelveset:NoComplexCall;REDMOND\tomat"
Outer DLR Change: Tweaks outer layer DynamicSiteHelpers to publish delegate
type factory method (this class will hopefully go away as soon as
LambdaExpression provides the same functionality).
Ruby changes: Removes ComplexCallHelper and other
Ideally, yes, but we need to figure out how to make it easy.
JD
-Original Message-
From: Mike Moore <[EMAIL PROTECTED]>
Sent: November 24, 2008 5:04 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] IronRuby moving to Github
On Mon, Nov 24, 2008 at 5:43 PM, Jim Deville <
Alright then :)
-Original Message-
From: Curt Hagenlocher
Sent: Monday, November 24, 2008 5:46 PM
To: Tomas Matousek; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Code Review: RubyClrInterop06
Unfortunately, GetParameters() doesn't return a type array -- i
Unfortunately, GetParameters() doesn't return a type array -- it returns a
ParameterInfo array. Here we see the evil of "var" -- it hides the actual type
:).
I'll look for opportunities to split the method;
-Original Message-
From: Tomas Matousek
Sent: Monday, November 24, 2008 4:03 PM
This is absolutely brilliant and same here - i'm keen to be of some
assistance (although i'm more passionate than knowledgable about ironruby).
On Tue, Nov 25, 2008 at 11:30 AM, Michael Letterle <
[EMAIL PROTECTED]> wrote:
> You have no idea what this news means to me. It's like... IronRuby is
>
On Mon, Nov 24, 2008 at 5:43 PM, Jim Deville <[EMAIL PROTECTED]> wrote:
> We still need contribution agreements, but that is no different than Apache,
> Mozilla, and other major Open Source projects.
>
> So is it the lieutenants' responsibility to ensure that whoever they pull
code from has an a
We still need contribution agreements, but that is no different than Apache,
Mozilla, and other major Open Source projects.
JD
-Original Message-
From: Mike Moore <[EMAIL PROTECTED]>
Sent: November 24, 2008 4:12 PM
To: ironruby-core@rubyforge.org
Subject: Re: [Ironruby-core] IronRuby m
You have no idea what this news means to me. It's like... IronRuby is
really getting started...
More then willing to continue helping in any way I can. :)
On Mon, Nov 24, 2008 at 7:05 PM, Jim Deville <[EMAIL PROTECTED]> wrote:
> The IronRuby project is a community project, and has contributors
Whoo hoo! Great job guys! This is very exciting. One question though, will
folks still need to have a signed agreement to contribute code?
On Mon, Nov 24, 2008 at 5:05 PM, Jim Deville <[EMAIL PROTECTED]> wrote:
> The IronRuby project is a community project, and has contributors inside
> and outs
The IronRuby project is a community project, and has contributors inside and
outside of Microsoft. We have integrated the work of several external folks
into the product (thanks!), and we are making rapid progress.
We'd like to try to make things easier. We'd like to not be in the way of
commun
In DefineConstructors, newParams seems to be unnecessarily copied.
Wouldn't it be better to do:
Type[] newParams;
Type[] baseParams = baseCtor.GetParameters();
if (has ruby class) {
newParams = baseParams;
} if (is serializer) {
newParams = baseParams;
} else {
...
newPrams = ArrayUtils.I
tfpt review "/shelveset:RubyClrInterop06;REDMOND\curth"
Comment :
Create constructors on generated types that match each base class constructor
Allocator logic not yet updated to use new constructors
--
Curt Hagenlocher
[EMAIL PROTECTED]
RubyClrInterop06.diff
Description: RubyClrInterop06.diff
14 matches
Mail list logo
