Re: [Ironruby-core] Code Review: scripts

2009-03-10 Thread Jim Deville
Ruby Dev.bat: Can the RUBY19_EXE check for its existence first (so I can override it, for example). I'd also like to not differentiate between GIT and non-GIT, with my comment below, we don't need the GIT env. Variable. Common.rb: I would say get rid of the nested if on line 42. If ROWAN_BIN, u

[Ironruby-core] Code Review: scripts

2009-03-10 Thread Shri Borde
tfpt review "/shelveset:scripts;REDMOND\sborde" Comment : Code change: Small fix in Shell\CommandLine.cs to deal with newlines consistently (user-reported issue). Scripts: Moves RunRSpec.cmd and irtests.bat from Merlin\Main\Scripts to Merlin\Languages\Ruby\Scripts so that they a