[Ironruby-core] Status of rubygems unit tests

2009-03-16 Thread Shri Borde
I have been working on making the rubygem unit tests (from git://github.com/vvs/rubygems.git) pass with IronRuby. When I started, the results looked like this. 707 tests, 1170 assertions, 9 failures, 352 errors, 1 skips Half the tests (9+352/707) were failing (or half were passing depending on

[Ironruby-core] Code Review: DMO1

2009-03-16 Thread Tomas Matousek
tfpt review "/shelveset:DMO1;REDMOND\tomat" Comment : - Checks for an invalid number of arguments is passed to an attribute setter/getter or struct field setter/getter. - Implements correct splatting of arguments to Delegate constructor and enables previously failing tests. -

Re: [Ironruby-core] Accessing the return value from a Dsl

2009-03-16 Thread Paul Cowan
Hi, For anyone who is interested, I managed to solve this by creating a singleton to house an instance of the BuildMetaData class. My Ruby code ended up looking like this: module MetaBuilder module Dsl module Main def install(name, &block) yield self if block_given? e

[Ironruby-core] Review : Zlib::Deflate fix

2009-03-16 Thread Shri Borde
http://github.com/shri/ironruby/commit/ce7438b4c038dc8937f59758f33c387e139aea6a Tomas, if you sync to g...@github.com:shri/ironruby.git and run Languages\Scripts\bat\dev.bat, you should be able to run this command to get a much better diffing experience. For this change, the URL above is simpler

Re: [Ironruby-core] Recommendations for (IronRuby) gem packaging ?

2009-03-16 Thread Daniele Alessandri
2009/3/16 Thibaut Barrère : >> Isn't "platform" used to identify a gem as a JRuby gem? Granted, it's not >> perfect, but having IronRuby gems set the platform to "ironruby" would seem >> to make sense with the current state of rubygems. Is there a reason not to >> do this, and (other than waiting

Re: [Ironruby-core] Code Review: irtestfix

2009-03-16 Thread Tomas Matousek
Looks good. Tomas -Original Message- From: Jim Deville Sent: Monday, March 16, 2009 12:20 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: irtestfix tfpt review "/shelveset:irtestfix;REDMOND\jdeville" Comment : * Removes RunRspec *

[Ironruby-core] Code Review: irtestfix

2009-03-16 Thread Jim Deville
tfpt review "/shelveset:irtestfix;REDMOND\jdeville" Comment : * Removes RunRspec * Path correction in Dev.bat to point to ruby-1.9.1p0 instead of 1.9.0-0 * Fixes irtests.bat to work with new mspec setup * Fixes bug/suggestion from JB Evain to print the current runtime as part of the

[Ironruby-core] Accessing the return value from a Dsl

2009-03-16 Thread Paul Cowan
Hi, I am trying to create a Dsl which will have instances that live in individual Dsl .rb files and then run them from the CLR. I want to create and set the values of the Clr object in IronRuby and then somehow have access to the CLR object after the .rb Dsl instance file has run. Here is my Clr

Re: [Ironruby-core] Recommendations for (IronRuby) gem packaging ?

2009-03-16 Thread Thibaut Barrère
> > Isn't "platform" used to identify a gem as a JRuby gem? Granted, it's not > perfect, but having IronRuby gems set the platform to "ironruby" would seem > to make sense with the current state of rubygems. Is there a reason not to > do this, and (other than waiting for changes to rubygems) is the

Re: [Ironruby-core] Code Review: shrigitpull

2009-03-16 Thread Shri Borde
Looks good ofcourse :) -Original Message- From: Jim Deville Sent: Sunday, March 15, 2009 11:17 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: shrigitpull tfpt review "/shelveset:shrigitpull;REDMOND\jdeville" Comment : This shelveset