Re: [Ironruby-core] Code Review: gitpull3

Hmmm, duplicate code reviews now, one for when they are in a git branch, and one for when we pull it into ironruby? > -Original Message- > From: Jim Deville > Sent: Friday, April 03, 2009 3:21 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core@rubyforge.org > Subject: Code Revi

Re: [Ironruby-core] FW: File.executable? always returns false on Windows machine

Yes, Windows does not have a comparable attribute. However, I can't figure out how MRI running on Windows implements this since I am getting a different behavior than what other folks are. IronRuby uses the ".exe" extension as a sort of "executable bit". Don't know what MRI on Windows does thoug

Re: [Ironruby-core] FW: File.executable? always returns false on Windows machine

We should probably return true if the extension is in PATHEXT. This should return true for EXE,COM, CMD, BAT, PS1 (if you have Powershell). It would be nice if we could inspect whatever assoc touches, so that if I add an assoc and filetype for RB, it becomes executable. JD From: ironruby-core-

Re: [Ironruby-core] FW: File.executable? always returns false on Windows machine

On *nix systems it would return true if the executable bit is set and false if it's not. Windows doesn't really have a comparable attribute since files are "categorized" based on extension, hence .exe acting as a sort of "executable bit". On Fri, Apr 3, 2009 at 1:36 PM, Shri Borde wrote: > Any

Re: [Ironruby-core] Status of rubygems unit tests

Thanks for the update. I can add this to the runs of http://ironruby.info so we have up-to-date stats about RubyGems. From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Shri Borde Sent: Friday, April 03, 2009 2:15 PM To: ironruby-core@rubyforge.or

Re: [Ironruby-core] Status of rubygems unit tests

Here are the latest results: 728 tests, 2021 assertions, 26 failures, 35 errors, 4 skips Latests results will be available at http://www.ironruby.net/Documentation/How_do_I_install_additional_gems%3f. The total number of tests increased because we moved from RubyGems version 0.9 something to t

Re: [Ironruby-core] Code Review: Bug Regressions and .NET interop

From: Jimmy Schementi Sent: Friday, April 03, 2009 1:47 PM To: Jim Deville; ironruby-core@rubyforge.org; IronRuby External Code Reviewers Subject: RE: Code Review: Bug Regressions and .NET interop Posted comments on github, but here they are also: * 'represents the program name' looks

Re: [Ironruby-core] Code Review: Bug Regressions and .NET interop

Posted comments on github, but here they are also: * 'represents the program name' looks strange, asserting that the splitted string (?) equals a array with two elements, both containing the expanded path the string represented. How does that make sense? Jim explained this one, and no

Re: [Ironruby-core] Review: File.chmod

Test looks good. JD From: Tomas Matousek Sent: Friday, April 03, 2009 11:00 AM To: Curt Hagenlocher; Shri Borde; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Review: File.chmod You can use RubyContext.Inspect in the DebugView. Other than that code changes look g

[Ironruby-core] Requesting contributions to IronRuby

We are getting closer to the V1 release of IronRuby which is planned for summer this year. The implementation has become fairly complete and usable in a lot of scenarios. Over the last few months, we have also improved our processes to make it easier for the community to contribute to the proje

Re: [Ironruby-core] Review: File.chmod

You can use RubyContext.Inspect in the DebugView. Other than that code changes look good. Tomas From: Curt Hagenlocher Sent: Friday, April 03, 2009 10:53 AM To: Shri Borde; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Review: File.chmod The comment "// TODO: imp

[Ironruby-core] Review: File.chmod

http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81 9fc3048beb4a315ec7ac3dc82908da8f92bf1a07 * Implements File.chmod * File.readable? should return false if the given filename does not exist *

Re: [Ironruby-core] Review: File.chmod

The comment "// TODO: implement this correctly for windows" could probably be removed; it's hard to envision chmod doing anything differently under Windows than what you've already implemented. From: Shri Borde Sent: Friday, April 03, 2009 10:42 AM To: IronRuby External Code Reviewers Cc: ironru

[Ironruby-core] FW: File.executable? always returns false on Windows machine

Anyone know what File.executable? is supposed to do? For me, it always returns false. For Jim, Tomas and others, it always returns true no matter what the file extension is. Any idea why we might be getting different results? FWIW, the current IronRuby implementation returns true if the file ext

[Ironruby-core] Code Review: Bug Regressions and .NET interop

Some more changes. Mostly closing bugs and adding .NET interop tests. Commit range is 90392fff to a39daeae on git://github.com/jredville/ironruby.git. I rebased this time, so you should be able to just grab that range and see only my diffs. * closing Rubyforge 15060

Re: [Ironruby-core] defined?(xxx) behaves differently when called from Silverlight

Jb Evain wrote: > On 4/1/09, Thibaut Barr貥 wrote: >> Can anyone else reproduce that issue (or is it something known >> already), or is my silverlight install messing up ? > > Well, there's no System.Windows.Froms.Control in silverlight to begin > with. > > defined?(System::Windows::Applicatio