Re: [Ironruby-core] Rails ActionPack tests

2009-04-23 Thread Daniele Alessandri
The numbers look good. I've never used RoR before (well I've never ever installed it) and I don't know almost anything about it, so I'm not sure if I can be of any help in this area but I'll try digging a little into those failures. PS: yeah, I might be one of the very few who doesn't really care

Re: [Ironruby-core] Planning?

2009-04-23 Thread Jimmy Schementi
Ivan, I’m not sure if anyone ever replied to this, but I can help clarify some things for you. http://en.oreilly.com/oscon2009/public/schedule/detail/7965 IronRuby will be 1.0 by Oscon2009. I’m showing what we’ve got so far with Rails at RailsConf in a couple weeks. I’ve been updating the websi

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Daniele Alessandri
Ha! I got caught :-) The duplicated logic is there precisely because I, too, couldn't think of a place to share that small piece of code in a good way, so I just coded it like that for now but I'll ponder about that for the next commit. OK for the specs. Thanks, Daniele On Thu, Apr 23, 2009 at 22

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Jim Deville
Can you add specs for rindex that expose the bug you fixed? Also, is there any shared place that you could put the following code: if (self.Count < originalSize) { i = originalSize - i - 1 + self.Count; originalSize = self.Count; } It would be nice to g

[Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Daniele Alessandri
Hi, I just pushed two fixes on my repository, the first one addresses a bug in Array#rindex (there was a bug in my last commit) and the second one makes Array#reverse_each compliant with the rubyspecs. http://github.com/nrk/ironruby/commit/d2b18f5d01a49cb62a2ea0c205e1cf1233ac94e0 >From the commit

Re: [Ironruby-core] Code Review: core/env/clear

2009-04-23 Thread Jim Deville
Looks good! Good to see that you've found your way around :) JD From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Tim Chen (SDO) Sent: Thursday, April 23, 2009 11:53 AM To: ironruby-core@rubyforge.org Subject: [Ironruby-core] Code Review: core/en

[Ironruby-core] Code Review: core/env/clear

2009-04-23 Thread Tim Chen (SDO)
Hi all! I've just started to learn IronRuby a week or two before, and Shri showed me through screenshare about mspec and fixing rubyspec bugs in general. So for my first contribution, I just did a one line change to know the process better. Here it is: http://github.com/tnachen/ironruby/comm

Re: [Ironruby-core] Strange behavior when redefining methods on object instances (possible bug)

2009-04-23 Thread Daniele Alessandri
Bug report filed here: http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=761 Thanks, Daniele On Wed, Apr 22, 2009 at 17:37, Tomas Matousek wrote: > Please file a bug. > > Thanks, > Tomas > > -Original Message- > From: ironruby-core-boun...@rubyforge.org > [mailto:ironruby-core-