Re: [Ironruby-core] Code Review: ProGenFix

2009-06-06 Thread Curt Hagenlocher
Ah, I see. Still, something strikes me as odd about the name, but I don't feel strongly about it. -Original Message- From: Tomas Matousek Sent: Saturday, June 06, 2009 3:57 PM To: Curt Hagenlocher; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core@rubyforge.org Sub

Re: [Ironruby-core] Code Review: ProGenFix

2009-06-06 Thread Tomas Matousek
You mean IsNestedProteced()? "Nested" feels superfluous since only nested types could be protected. Tomas -Original Message- From: Curt Hagenlocher Sent: Saturday, June 06, 2009 2:05 PM To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core@rubyfor

Re: [Ironruby-core] Code Review: ProGenFix

2009-06-06 Thread Curt Hagenlocher
Changes look good overall. I'm not sure that Type.IsProtected() is an intuitive name; maybe Type.IsNested() would be clearer? -Original Message- From: Tomas Matousek Sent: Saturday, June 06, 2009 12:51 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core@rubyfo

[Ironruby-core] Code Review: ProGenFix

2009-06-06 Thread Tomas Matousek
tfpt review "/shelveset:ProGenFix;REDMOND\tomat" DLR, Python, Ruby. Fixes Ruby calls to protected generic methods. Adds CompilerHelpers.IsProtected() as an alias for IsFamily || IsFamilyOrAssembly. Tomas ProGenFix.diff Description: ProGenFix.diff

Re: [Ironruby-core] How can I cancel a running script

2009-06-06 Thread Tomas Matousek
The script itself might check some (global) variable time to time and if it is "on" terminate itself. For example, use Kernel#select with a timeout instead of sleep. Tomas -Original Message- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Beha

Re: [Ironruby-core] Net/http post_form problem

2009-06-06 Thread Jim Deville
It wouldn't surprise me if there is a bug. If you look at the Mspec tags, you'll see that a lot of the net/http library is critical (meaning it hangs or crashes the interpreter). Feel free to file a bug, or take a look to start cleaning it up (if the SOAP stuff isn't already keeping you busy ;))

Re: [Ironruby-core] something has changed

2009-06-06 Thread Ivan Porto Carrero
So the signatures I'm talking about look like this: protected internal void UpdateModel(TModel model) where TModel : class { UpdateModel(model, null, null, null, ValueProvider); } protected internal void UpdateModel(TModel model, string prefix) where TModel : cl

Re: [Ironruby-core] something has changed

2009-06-06 Thread Curt Hagenlocher
It would be good to be more specific about the example. Consider class Foo { public void Bar(int, object); public void Bar(int, string); } If I call "Foo.new.Bar 1, nil", then this is an ambiguous call and you should be forced to specify which overload you want. In statically-typed lang

Re: [Ironruby-core] something has changed

2009-06-06 Thread Ivan Porto Carrero
In C# you can pass null to a string parameter and it won't complain I expected this to work from ironruby too because it did before. So I want to find out if that is going to be a permanent change or if it is a bug :) so i'm not talking about an empty instance of String being nil but it's about i

Re: [Ironruby-core] something has changed

2009-06-06 Thread Will Green
Just curious, but why should nil count as a string object? In C Ruby, nil is an object, and an empty string object is not nil: irb(main):001:0> n = nil => nil irb(main):002:0> s = String.new => "" irb(main):003:0> n.nil? => true irb(main):004:0> s.nil? => false irb(main):005:0> s == n => false irb

[Ironruby-core] something has changed

2009-06-06 Thread Ivan Porto Carrero
Hi Since this weeks updates to ironruby ironrubymvc is completely broken. The way overloads are selected now is different. for example asp.net mvc has a bunch of methods defined on Controller that are protected internal ie. protected internal void View(string, string) it also has an overload View

[Ironruby-core] Net/http post_form problem

2009-06-06 Thread Shay Friedman
Hi, I'm trying to execute the next code: require 'net/http' require 'uri' puts "starting..." url = URI.parse('http://localhost/test3/demo.aspx') puts "retrieving..." res = Net::HTTP.post_form(url, {"FullName" => "Shay Friedman"}) puts "writing" File.open("test.txt","w"