Yes, this is the right process - fix it in a branch and send a pull request.
The change looks great! Merged into main and closed the bug.
Thanks,
Tomas
-Original Message-
From: ironruby-core-boun...@rubyforge.org
[mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Nicholas Radford
>
> Quick question guys, when pushing this to my repo on github, should I
> push to a topic branch or push to master?
>
Well I pushed it to a topic branch, just in case you guys required changes :)
As the contributing documentation says, would someone mind giving me a
code review?
Code can be fo
On 5 May 2011 09:32, Nicholas Radford wrote:
>>> I'm partial to option 2. As Ruby is already a slow language, we should try
>>> to optimize it wherever possible. In addition, 2 keeps to the trend in other
>>> .NET languages. For example, I believe LINQ takes advantage of existing
>>> methods on Li
