I've updated the pull request as per Tomas' code review comments.
- Removed ISpecialRubyMarshalling interface in favour of keeping the code
all in the Marshal
- Only implement Exception#==, not === and eql?
- Implement proper Exception comparison logic to match MRI
- Change the Marshal#ReadObject
There is a lot of work to do around exceptions in general. I wouldn't start
digging into it if I were you :). I'm thinking of some core changes in how we
map Ruby to .NET exceptions... it will take me some time to get to it though. I
would not worry about all these Errno exceptions for now unles
Thanks for that.
After the code review comments about Exception#== I was running the
Exception specs. 3 fail against ruby 1.9.2p290 (2011-07-09) [i386-mingw32]
I don't have access to a linux/mac system at work to check if they pass on
non-windows platforms, but it doesn't look like there's anyt
1) Partly. We are in progress of updating them. Since we've added more specs
and sometimes corrected existing ones this needs to be done with care. The
current progress is captured here:
https://gist.github.com/1159998
After we are done with this process of bringing the specs up to date we can
I've just run mspec under the Languages\Ruby\Tests\mspec\rubyspec\core
folder against MRI 1.9.2p0 (which is checked into the ironlanguages-main
git repo), and it crashes with a segfault in putc_spec.rb
I then tried running against MRI 1.9.2p290 and I get the following:
1518 files, 9618 e