Ok, cool. Sounds good.
Are you thinking of a method in MutableString like IncrementVersion()? Or
something?
-Original Message-
From: Tomas Matousek
Sent: Thursday, July 10, 2008 6:46 PM
To: Dave Remy; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Code
tfpt review "/shelveset:StringGsubVersion;REDMOND\dremy"
Comment :
This change fixes all of the gsub, each, and each_line specs. Added
aditional tests to gsub spec. The excluded gsub tests are only failing on
unimplemented string methods (lstrip!, rstrip!) Implemented simple
mutablestring
tfpt review "/shelveset:StringGsubEach;REDMOND\dremy"
Comment :
Changes to for string.gsub and string.each (and each_line) to run clean. The
most significant change is to track version in MutableString. This version is
bumped on any mutation and functions that iterate (each, each_line, gsub)
tfpt review "/shelveset:StringGsubWithStringPatternAndBlock;REDMOND\dremy"
Comment :
This change fixes the rest of the gsub coverage minus one (String#gsub with
pattern and block raises a RuntimeError if the string is modified while
substituting). We had a similar issue implementing squeeze s
tfpt review "/shelveset:StringGsubWithPattern;REDMOND\dremy"
Comment :
Changes for string.gsub with pattern ruby specs to pass. The following tests
now pass:
String#gsub with pattern, replacement replaces \& and \0 with the complete
match
String#gsub with pattern, replacement replaces \`
tfpt review "/shelveset:StringElementReferenceAndSlice;REDMOND\dremy"
Comment :
Changes for [] (alias: slice) to run clean. One small fix to not flow taint.
Also, fix a small bug that was using a deprecated implicit conversion between
string and MutableString.
StringElementReferenceAndSl
tfpt review "/shelveset:StringCenterDeleteEach;REDMOND\dremy"
Comment :
Changes for string.center (adjustements for code review comments),
string.delete, and string.each/each_line to pass specs.
Also, forgot to update excludes for squeeze/squeeze! implementation in last
checkin.
StringCe
"a"
s.each { s[0] = "b"}
=> "baa\naaa"
This looks like MRI is relying on copy on write semantics to determine whether
a string was modified? Jim, says this is not the behavior for 1.9.
This seems like a good candidate for IR diverging on ...
rem
From: [
uld record or otherwise
influence the type of exception that we expect to throw.
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Dave Remy
Sent: Sunday, June 29, 2008 3:58 PM
To: ironruby-core@rubyforge.org
Subject: [Ironruby-core] MutableString.each
I am working on one of the specs f
I am working on one of the specs for string.each which is failing. This is
the spec that is failing.
it "raises a RuntimeError if the string is modified while substituting" do
str = "hello\nworld"
should_raise(RuntimeError) { str.send(cmd) { str[0] = 'x' } }
end
The idea is that th
tfpt review "/shelveset:MutableStringCenter;REDMOND\dremy"
Comment :
Made changes for MutableString.center to pass specs. Included flowing taint
correctly, subclassing, changing signature to use object and then doing manual
conversion.
MutableStringCenter.diff
Description: MutableStringCe
uot;) => "puters put balls"
be
"putters putt balls".squeeze("m-z") => "puters put balls"
Robert.
On Wed, Jun 25, 2008 at 6:55 PM, Dave Remy <[EMAIL PROTECTED]<mailto:[EMAIL
PROTECTED]>> wrote:
tfpt review "/shelveset:MutableS
tfpt review "/shelveset:MutableStringSqueeze;REDMOND\dremy"
Comment :
Implement String.squeeze and String.squeeze!
Passes RubySpec tests. Passes Unit tests.
MutableStringSqueeze.diff
Description: MutableStringSqueeze.diff
___
Ironruby-core maili
tfpt review "/shelveset:FileStatFix;REDMOND\dremy"
Comment :
Fixes bug [#20412] File::Stat
FileStatFix.diff
Description: FileStatFix.diff
___
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core
14 matches
Mail list logo
