Re: [Ironruby-core] Code Review: GenericMethodsAndOverloads

2009-01-13 Thread Tomas Matousek
TryBindGenericParameters should look like: foreach (var method in MethodBases) { if (method.IsGenericMethodDefinition) { if (typeArguments.Length == method.GetGenericArguments().Length) { Debug.Assert(!(method is ConstructorI

Re: [Ironruby-core] Code Review: GenericMethodsAndOverloads

2009-01-13 Thread Curt Hagenlocher
Changes look good overall. In RubyMethodGroupInfo.TryBindGenericParameters, an empty set of types will return all methods in MethodBases whether or not they're generic. What's the reason for this behavior? There's a chunk of code that was added to Utils.cs that's indented too far. -Origin

[Ironruby-core] Code Review: GenericMethodsAndOverloads

2009-01-12 Thread Tomas Matousek
tfpt review "/shelveset:GenericMethodsAndOverloads;REDMOND\tomat" Implements generic methods parameters binding and explicit overload selection. Adds methods Method/UnboundMethod#of and Method/UnboundMethod#overloads. Method#of takes a list of Ruby classes or CLR types and returns a Metho