Re: [Ironruby-core] Code Review: HashFixes

2009-07-01 Thread Jimmy Schementi
No takers? I've documented this at http://ironruby.net/Documentation/Ruby_Standard_Library/Modifications so if anyone wants to bite the info is there. ~js > -Original Message- > From: Jimmy Schementi > Sent: Tuesday, June 23, 2009 2:45 PM > To: Tomas Matousek; IronRuby External Code Re

Re: [Ironruby-core] Code Review: HashFixes

2009-06-23 Thread Jimmy Schementi
How are we going to make sure this gets back into REXML and RubyGems? We shouldn't ship significantly different versions of the Ruby stdlib, as people will expect to switch to any version of the stdlib without issues. My first thought is to have someone in the community step up to propose these

[Ironruby-core] Code Review: HashFixes

2009-06-23 Thread Tomas Matousek
tfpt review "/shelveset:HashFixes;REDMOND\tomat" Fixes implementation of hash methods in REXML and RubyGems. The current implementation is incorrect since it sums hash codes of subcomponents potentially overflowing to Bignum. This issue is mainly exposed when calculating hash of an array. A