Ruby changes are good.
From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: IronRuby Thread fixes
Affects: Microsoft.Scripting.Core.dll and IronRuby
tfpt r
DLR change looks great!
From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: IronRuby Thread fixes
Affects: Microsoft.Scripting.Core.dll and IronRuby
tfpt
Test changes look good. I'd like to see the RunRSpec.cmd use ruby to run mspec
with args of ci and -t "path to ir", which is what the rakefile sets up as a
command line.
JD
From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR
Affects: Microsoft.Scripting.Core.dll and IronRuby
tfpt review "/shelveset:Thread;REDMOND\sborde"
Comment :
Fixes to all the currently disabled Thread tests
Thread#stop/Kernel#sleep use an Event which can be signalled from other
threads, instead of using Thread.Sleep
ThreadOps.
