Re: [Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Shri Borde
Good catch. I have fixed the issue. Also updated the tests according to Jim's suggestions. Also, the last test using Thread.kill was wrong but seemed to succeed since "flunk" fails silently when used on the non-main thread. New patch included if you want to take a look. Will go ahead and submit

Re: [Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Curt Hagenlocher
The implementation of ThreadOps._CriticalMonitor and ThreadOps._IsInCriticalRegion as class-level fields will cause state information to leak between ScriptRuntimes. These should probably be put on the RubyContext, which can either be done directly or by using RubyContext.GetOrCreateLib

Re: [Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Jim Deville
I'd rather see the functionality in irtest.bat in IronRuby's run.bat. That way it runs with run 0. The specs will probably need to be cleaned up to meet RubySpec style guidelines, and to get Brian to approve them. Go ahead and commit them, and I can clean them up, or we can work on them togeth

[Ironruby-core] Code Review: Thread.critical

2009-01-05 Thread Shri Borde
tfpt review "/shelveset:critical;REDMOND\sborde" Microsoft.Scripting.dll: Fix to interpreter to get better stack trace even when call-site caching kicks in. The try-catch needs to be added to all code that can throw an exception in the interpreter (or preferably in one function like Inte