Re: [Ironruby-core] Code Review: Update RubySpec

Finished offline and F2F with Tomas. JD From: Tomas Matousek Sent: Wednesday, April 22, 2009 11:33 AM To: Jim Deville; ironruby-core@rubyforge.org; IronRuby External Code Reviewers Subject: RE: Code Review: Update RubySpec I see - umask maintains a global state. Any global state maintained by l

Re: [Ironruby-core] Code Review: Update RubySpec

I see - umask maintains a global state. Any global state maintained by libraries should be stored on RubyContext, not in static fields. Use RubyContext.GetOrCreateLibraryData/TryGetLibraryData (if you search the library you'll find some use cases). Also defining a struct just to store an integer

Re: [Ironruby-core] Code Review: Update RubySpec

Umask is a mask on file creation. By itself it does nothing more than what I've implemented (that I can tell), but File.open (and other file creation methods) should look at it to derive the default permissions. The attached script shows the basic idea, and here's it's output: [9] > ruby .\temp

Re: [Ironruby-core] Code Review: Update RubySpec

What is umask supposed to do? Tomas From: Jim Deville Sent: Tuesday, April 21, 2009 8:12 PM To: ironruby-core@rubyforge.org; IronRuby External Code Reviewers Subject: Code Review: Update RubySpec I'm updating RubySpec to the newest revision from Git. Most of this is boring stuff; just updating

[Ironruby-core] Code Review: Update RubySpec

I'm updating RubySpec to the newest revision from Git. Most of this is boring stuff; just updating files and rebuilding tags. However, a couple of these commits are code changes to help the specs run smoother. JD * add ci_files to default.mspec so mspec ci works