Re: [Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
It is. The test is fully local. -Original Message- From: Jimmy Schementi Sent: Monday, May 04, 2009 10:04 PM To: Jim Deville; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Code Review: firewallwarning This if fine as long as only this machine hits the serve

Re: [Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jimmy Schementi
This if fine as long as only this machine hits the server ... > -Original Message- > From: Jim Deville > Sent: Monday, May 04, 2009 9:59 PM > To: IronRuby External Code Reviewers > Cc: ironruby-core@rubyforge.org > Subject: Code Review: firewallwarning > > RESENDING with diff: > tfpt revi

[Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
RESENDING with diff: tfpt review "/shelveset:firewallwarning;REDMOND\jdeville" Comment : This simple change fixes a firewall warning that gets kicked up in the test lab. The change is simply to change the listening address from 0.0.0.0 (bind on all addresses) to 127.0.0.1 (loopback). fi

[Ironruby-core] Code Review: firewallwarning

2009-05-04 Thread Jim Deville
tfpt review "/shelveset:firewallwarning;REDMOND\jdeville" Comment : This simple change fixes a firewall warning that gets kicked up when running Net::HTTP specs. The change is simply to change the listening address from 0.0.0.0 (bind on all addresses) to 127.0.0.1 (loopback). firewallw