Sounds good
-Original Message-
From: Shri Borde
Sent: Thursday, January 21, 2010 4:37 PM
To: Jim Deville; IronRuby External Code Reviewers
Cc: [email protected]
Subject: RE: Code Review: rails2
To enable active record tests, we need to check in the ironruby-sqlserver gem
(not
To enable active record tests, we need to check in the ironruby-sqlserver gem
(not hard), and implement ensure_test_databases (a bit more work to figure out).
disable_unstable_tests should be called. Good catch.
Removed line 82 of active_record_tests.rb
-Original Message-
From: Jim Devi
* irtests.rb: Reminder for me: why is active record commented out?
* utr.rb: Disable_unstable_tests doesn't appear to get called, is that
intentional?
* active_record_tests.rb, line 82: I would get rid of the empty method, it's
already defined
Otherwise looks good.
JD
-Original Message-
tfpt review "/shelveset:rails2;REDMOND\sborde"
Comment :
Added active_resource and action_mailer tests to irtests.rb
Added a category (disable_unstable_tests) of unstable tests to utr.rb so that
we can track non-deterministic failures. Also a category
(exclude_critical_files) for critic
