Re: [Ironruby-core] Code Review: rakecrossplatform

2009-01-02 Thread Jim Deville
Committing with Michael's suggestion. JD From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Michael Letterle Sent: Wednesday, December 31, 2008 8:23 PM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Code Review: rakecrosspla

Re: [Ironruby-core] Code Review: rakecrossplatform

2008-12-31 Thread Michael Letterle
By the by, forward slashes are acceptable as path separators in windows as well as under unix. This /may/ be more acceptable as it's clearer, IMHO. On Wed, Dec 31, 2008 at 4:29 PM, Jim Deville wrote: > I'm going to directly commit this since it doesn't affect tests. > > JD > > -Original Mes

Re: [Ironruby-core] Code Review: rakecrossplatform

2008-12-31 Thread Jim Deville
I'm going to directly commit this since it doesn't affect tests. JD -Original Message- From: Curt Hagenlocher Sent: Wednesday, December 31, 2008 1:17 PM To: Jim Deville; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Code Review: rakecrossplatform Looks go

Re: [Ironruby-core] Code Review: rakecrossplatform

2008-12-31 Thread Curt Hagenlocher
Looks good! -Original Message- From: Jim Deville Sent: Wednesday, December 31, 2008 12:21 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: rakecrossplatform tfpt review "/shelveset:rakecrossplatform;REDMOND\jdeville" Comment : Fixes the

[Ironruby-core] Code Review: rakecrossplatform

2008-12-31 Thread Jim Deville
tfpt review "/shelveset:rakecrossplatform;REDMOND\jdeville" Comment : Fixes the imports to reference the files in a platform agnostic way. rakecrossplatform.diff Description: rakecrossplatform.diff ___ Ironruby-core mailing list Ironruby-core@r