Re: [Ironruby-core] Review: Array#hash and irtests.bat

2009-04-20 Thread Jim Deville
Test looks good. JD From: Tomas Matousek Sent: Monday, April 20, 2009 9:32 AM To: Shri Borde; IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Review: Array#hash and irtests.bat Re RubyArray.Equals(object)/GetHashCode: is it desirable to use value equality here? The

Re: [Ironruby-core] Review: Array#hash and irtests.bat

2009-04-20 Thread Tomas Matousek
Re RubyArray.Equals(object)/GetHashCode: is it desirable to use value equality here? These methods are only used from .NET libraries - e.g. if the array is added into a dictionary as a key. Unless RubyArray is bound to a runtime its .NET hash/equality implementation won't be the same as Ruby's (

[Ironruby-core] Review: Array#hash and irtests.bat

2009-04-17 Thread Shri Borde
http://github.com/shri/ironruby/commit/7f3d766216c2fa533e208ac2a44b8de39cb03f7c * Fixes Array#hash to work with recursive arrays * Also updated ArraySpecs.recursive_array to produce a cycle of length 3. Previously, it was doing "a << a" multiple times, but this does not increase