Test looks good.
JD
From: Tomas Matousek
Sent: Friday, April 03, 2009 11:00 AM
To: Curt Hagenlocher; Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Review: File.chmod
You can use RubyContext.Inspect in the DebugView.
Other than that code changes look g
You can use RubyContext.Inspect in the DebugView.
Other than that code changes look good.
Tomas
From: Curt Hagenlocher
Sent: Friday, April 03, 2009 10:53 AM
To: Shri Borde; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Review: File.chmod
The comment "// TODO: imp
http://github.com/shri/ironruby/commit/9fc3048beb4a315ec7ac3dc82908da8f92bf1a07
GitDiff.bat c71e026eca1134d77a87bd792b1d93c60e32bf81
9fc3048beb4a315ec7ac3dc82908da8f92bf1a07
* Implements File.chmod
* File.readable? should return false if the given filename does not
exist
*
The comment "// TODO: implement this correctly for windows" could probably be
removed; it's hard to envision chmod doing anything differently under Windows
than what you've already implemented.
From: Shri Borde
Sent: Friday, April 03, 2009 10:42 AM
To: IronRuby External Code Reviewers
Cc: ironru
