Re: [Ironruby-core] Review: String#% and File.rename

2009-04-09 Thread Jim Deville
I would suggest using FileUtils.rm_rf instead of remove_dir at http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f#L1R13 You also don't need to require fileutils as it is required as part of MSpec. JD From: Shri Borde Sent: Thursday, April 09, 2009 12:06 PM To: Iron

Re: [Ironruby-core] Review: String#% and File.rename

2009-04-09 Thread Tomas Matousek
Looks good. Tomas From: Shri Borde Sent: Thursday, April 09, 2009 12:06 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Review: String#% and File.rename http://github.com/Jirapong/ironruby/commit/1eb5b389d849c5464f8d89090c7476a96f05c21e (Jirapong's fix) http://g

[Ironruby-core] Review: String#% and File.rename

2009-04-09 Thread Shri Borde
http://github.com/Jirapong/ironruby/commit/1eb5b389d849c5464f8d89090c7476a96f05c21e (Jirapong's fix) http://github.com/shri/ironruby/commit/2cb2802a316c48721875204aa83cf5d0fa85cf3f (my fixes) http://github.com/shri/ironruby/commit/e8f840f5c800fa62f4987b8904569491ae9a8ba0 (merge with irmain HEAD