Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-06-25 Thread Daniele Alessandri
Alessandri > Sent: Wednesday, June 24, 2009 4:23 PM > > To: ironruby-core@rubyforge.org > Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and > Array#reverse_each > > > > Thanks Jim! > > > > BTW currently my repository is about one month behind. I mus

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-06-24 Thread Jim Deville
s good. > >> JD > >> > >>> -----Original Message- > >>> From: > >>> ironruby-core-boun...@rubyforge.org<mailto:ironruby-core-boun...@rubyforge.org> > >>> [mailto:ironruby-core-<mailto:ironruby-core-> > >>>

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-06-24 Thread Daniele Alessandri
gt; boun...@rubyforge.org] On Behalf Of Daniele Alessandri > > Sent: Wednesday, June 24, 2009 1:30 PM > > To: ironruby-core@rubyforge.org > > Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and > > Array#reverse_each > > > > Hi, > > > >

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-06-24 Thread Jim Deville
ore- > boun...@rubyforge.org] On Behalf Of Daniele Alessandri > Sent: Wednesday, June 24, 2009 1:30 PM > To: ironruby-core@rubyforge.org > Subject: Re: [Ironruby-core] Review: fixes for Array#rindex and > Array#reverse_each > > Hi, > > It seems like this patch has gone unnoticed as it

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-06-24 Thread Daniele Alessandri
would be nice to get rid of the duplicated logic, but I can't think of >> where it should go. >> >> Other than that, looks good. >> JD >> >>> -Original Message- >>> From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core- >>>

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-05-31 Thread Daniele Alessandri
l 23, 2009 12:59 PM >> To: ironruby-core@rubyforge.org >> Subject: [Ironruby-core] Review: fixes for Array#rindex and >> Array#reverse_each >> >> Hi, >> I just pushed two fixes on my repository, the first one addresses a bug >> in Array#rindex (ther

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Daniele Alessandri
[mailto:ironruby-core- >> boun...@rubyforge.org] On Behalf Of Daniele Alessandri >> Sent: Thursday, April 23, 2009 12:59 PM >> To: ironruby-core@rubyforge.org >> Subject: [Ironruby-core] Review: fixes for Array#rindex and >> Array#reverse_each >> >> Hi, >&

Re: [Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Jim Deville
April 23, 2009 12:59 PM > To: ironruby-core@rubyforge.org > Subject: [Ironruby-core] Review: fixes for Array#rindex and > Array#reverse_each > > Hi, > I just pushed two fixes on my repository, the first one addresses a bug > in Array#rindex (there was a bug in my last

[Ironruby-core] Review: fixes for Array#rindex and Array#reverse_each

2009-04-23 Thread Daniele Alessandri
Hi, I just pushed two fixes on my repository, the first one addresses a bug in Array#rindex (there was a bug in my last commit) and the second one makes Array#reverse_each compliant with the rubyspecs. http://github.com/nrk/ironruby/commit/d2b18f5d01a49cb62a2ea0c205e1cf1233ac94e0 >From the commit