[ 
https://issues.apache.org/jira/browse/ARTEMIS-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815392#comment-17815392
 ] 

ASF subversion and git services commented on ARTEMIS-4640:
----------------------------------------------------------

Commit cdd341a1e86dc2fa066e6b6ff6926b930857608f in activemq-artemis's branch 
refs/heads/main from Robbie Gemmell
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=cdd341a1e8 ]

ARTEMIS-4640: move os-maven-plugin extension into a profile, fix 
artemis-commons reproducibility


> move extension added to aid 'offline' maven usage into a profile
> ----------------------------------------------------------------
>
>                 Key: ARTEMIS-4640
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4640
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>    Affects Versions: 2.32.0
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Major
>             Fix For: 2.33.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The changes in ARTEMIS-4153 to broke the reproducibility of the 
> artemis-commons module build. The extension being present leads to 
> OS-specific properties being embedded in the published pom, e.g see 
> https://repo1.maven.org/maven2/org/apache/activemq/artemis-commons/2.32.0/artemis-commons-2.32.0.pom
> The extension will be moved into a helper 'go-offline' profile so it can 
> still be used easily together with go-offline, even though its usefulness 
> actually seems limited.
> Even after running dependency:go-offline with a clean local repo, the build 
> doesnt actually immediately work offline since that doesnt actually grab 
> everything needed at build time. You still need to run the build online to 
> get the added bits needed.
> Instead, just running then normal build itself initially, it then does work 
> offline.
> (Its also questionable if dependency:go-offline will actually be around in 
> future, a Jira was already raised to remove it due to various issues with it: 
> MDEP-904 )



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to