[ 
https://issues.apache.org/jira/browse/ARTEMIS-4396?focusedWorklogId=878616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878616
 ]

ASF GitHub Bot logged work on ARTEMIS-4396:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Aug/23 11:37
            Start Date: 28/Aug/23 11:37
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #4586:
URL: https://github.com/apache/activemq-artemis/pull/4586#discussion_r1307133455


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateQueueMessage_V2.java:
##########
@@ -450,6 +468,9 @@ public void decodeRest(final ActiveMQBuffer buffer) {
       if (buffer.readableBytes() > 0) {
          groupRebalancePauseDispatch = 
BufferHelper.readNullableBoolean(buffer);
       }
+      if (buffer.readableBytes() > 0) {
+         internal = BufferHelper.readNullableBoolean(buffer);
+      }

Review Comment:
   Should it be possible for clients to remotely create 'internal' queues? I 
don't really see why we would want/need that to be possible now at this point 
when it hasnt been before? Also, is there any kind of access control needed on 
it?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 878616)
    Time Spent: 20m  (was: 10m)

> Improve support for "internal" address/queue property
> -----------------------------------------------------
>
>                 Key: ARTEMIS-4396
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4396
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to