[
https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558882#comment-15558882
]
Leif Walsh commented on ARROW-112:
--
Ok, cool. Glad I put them in separate commits then :)
> [C++] Style
[
https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558878#comment-15558878
]
Wes McKinney commented on ARROW-112:
I'd prefer to leave the enums as is and only fix the constants
[
https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558850#comment-15558850
]
Leif Walsh commented on ARROW-112:
--
I've done most of this I think, did you also want to change the values
[
https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558695#comment-15558695
]
Leif Walsh commented on ARROW-189:
--
Oh, I see, you still want downstream packagers to be able to
[
https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558688#comment-15558688
]
Leif Walsh commented on ARROW-189:
--
Right, so I'd delete that if I didn't know better. What do you use
[
https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558681#comment-15558681
]
Wes McKinney commented on ARROW-189:
see
Deneche A. Hakim created ARROW-329:
--
Summary: ComplexWriterImpl.setValueCount() doesn't set the value
count of its "root" container
Key: ARROW-329
URL: https://issues.apache.org/jira/browse/ARROW-329
[
https://issues.apache.org/jira/browse/ARROW-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558615#comment-15558615
]
Wes McKinney commented on ARROW-328:
Here's one reference:
Wes McKinney created ARROW-328:
--
Summary: [C++] Return shared_ptr by value instead of const-ref?
Key: ARROW-328
URL: https://issues.apache.org/jira/browse/ARROW-328
Project: Apache Arrow
Issue
[
https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558607#comment-15558607
]
Wes McKinney commented on ARROW-189:
OK by me to remove them so long as the Travis CI builds keep
[
https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558446#comment-15558446
]
Leif Walsh commented on ARROW-189:
--
I can take this, I have it working, just need to clean up the patch
11 matches
Mail list logo
