markjschreiber opened a new issue, #14844:
URL: https://github.com/apache/arrow/issues/14844

   ### Describe the enhancement requested
   
   I recently ran a profiler on a simple implementation of a sort and noticed 
that the VectorValueComparator spends quite a lot of time checking the values 
to be compared for `null` values. In this case I had already declared the 
`FieldType` to be `notNullable`. Unless I am misunderstanding something, the 
values cannot be `null` so the comparator is making unnecessary and expensive 
comparisons.
   
   As a test I made a comparator that skips the null tests and runs ~12% faster 
as a result. Based on this I think the `VectorValueComparator` should skip the 
`nul`l test for NonNullable `FieldTypes`.
   
   I'd be happy to contribute a change to do this if you think it would be 
reasonable.
   
   
   ### Component(s)
   
   Java


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to