[GitHub] [arrow-adbc] lidavidm commented on issue #55: [Format] Minor gaps with existing APIs

2022-08-11 Thread GitBox
lidavidm commented on issue #55: URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1212119635 > Is the idea that `RowCount` would do double duty as the number of rows in a result set OR the number of rows affected by an update/insert? Yeah, I don't see a reason to have

[GitHub] [arrow-adbc] lidavidm commented on issue #55: [Format] Minor gaps with existing APIs

2022-08-10 Thread GitBox
lidavidm commented on issue #55: URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211236715 Returning strings from a C API is a bit annoying and I'm not sure whether this is preferable, or if we want to go with an ODBC-style API (pass a caller-allocated buffer and length an

[GitHub] [arrow-adbc] lidavidm commented on issue #55: [Format] Minor gaps with existing APIs

2022-08-10 Thread GitBox
lidavidm commented on issue #55: URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211235028 Punting on paramstyle and last inserted ID, but adding row count and current catalog: ```diff commit 50b2e40d727c0a51029d7f5506c0696b3a19a3b9 Author: David Li Date:

[GitHub] [arrow-adbc] lidavidm commented on issue #55: [Format] Minor gaps with existing APIs

2022-08-10 Thread GitBox
lidavidm commented on issue #55: URL: https://github.com/apache/arrow-adbc/issues/55#issuecomment-1211184131 So looking into it - rowcount is easy to bind, but hard to support (lots of things don't support it or only support it for inserts) - that's OK. Flight SQL only exposes it for upd