[
https://issues.apache.org/jira/browse/ARROW-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539653#comment-16539653
]
Dimitri Vorona edited comment on ARROW-2701 at 7/11/18 7:23 AM:
----------------------------------------------------------------
I think the consensus was that we should solve this problem on another
level,and that there isn't a performant way of ensuring the safety of the read
buffers.
We should close this issue then, so it doesn't litter the issue queue.
was (Author: alendit):
I think the consensus was that we should solve this problem on another level,
since there isn't a performant way of ensuring the safety of the read buffers.
We should close this issue then, so it doesn't litter the issue queue.
> [C++] Make MemoryMappedFile resizable
> -------------------------------------
>
> Key: ARROW-2701
> URL: https://issues.apache.org/jira/browse/ARROW-2701
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Affects Versions: 0.9.0
> Reporter: Dimitri Vorona
> Assignee: Dimitri Vorona
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.10.0
>
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Hi,
> I don't see any reason for the MemoryMappedFile not to be resizable, e.g.
> like it is in Python stdlib. This patch changes the base class of
> MemoryMappedFile to ResizableBuffer and implements mmap resizing similar to
> [mmap.resize|https://github.com/python/cpython/blob/415bc46a78e785f357c8960ae70f18a6b6cccbb6/Modules/mmapmodule.c#L454]
> from python stdlib.
> If the change is ok, we should probably change the comment
> [here|https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_io.py#L577],
> too.
> Cheers,
> Dimitri.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
