[jira] [Commented] (ARROW-2856) [Python/C++] Array constructor should not truncate floats when casting to int

2018-07-17 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546813#comment-16546813 ] Antoine Pitrou commented on ARROW-2856: --- Yes, we raise on NaN as well: {code:python

[jira] [Commented] (ARROW-2856) [Python/C++] Array constructor should not truncate floats when casting to int

2018-07-16 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545473#comment-16545473 ] Wes McKinney commented on ARROW-2856: - NumPy _does_ raise with NaN, which aligns with

[jira] [Commented] (ARROW-2856) [Python/C++] Array constructor should not truncate floats when casting to int

2018-07-16 Thread Wes McKinney (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545428#comment-16545428 ] Wes McKinney commented on ARROW-2856: - I'm inclined to agree with [~pitrou] on this.

[jira] [Commented] (ARROW-2856) [Python/C++] Array constructor should not truncate floats when casting to int

2018-07-16 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545383#comment-16545383 ] Antoine Pitrou commented on ARROW-2856: --- This is consistent with Numpy behaviour. I