[jira] [Commented] (AVRO-3880) Upgrade maven-antrun-plugin to 3.1.0

2024-01-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810233#comment-17810233 ] ASF subversion and git services commented on AVRO-3880: --- Commit

Re: [PR] Fix Java doc typo in HadoopCodecFactory.java [avro]

2024-01-23 Thread via GitHub
martin-g commented on PR #2705: URL: https://github.com/apache/avro/pull/2705#issuecomment-1907498972 Thank you, @yaooqinn ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]

2024-01-23 Thread via GitHub
martin-g commented on PR #2643: URL: https://github.com/apache/avro/pull/2643#issuecomment-1907496888 I was waiting for a feedback from the reporter (@jslusher). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] AVRO-3900: [Rust] Make it possible to use custom names validators [avro]

2024-01-23 Thread via GitHub
rodneykeeling commented on PR #2643: URL: https://github.com/apache/avro/pull/2643#issuecomment-1906899024 This worked on my machine (both `SchemaNameValidator` and `SchemaNamespaceValidator` traits). Thanks for the work here! Is there anything else needed to get this merged (aside from

Re: [PR] AVRO-3641: Adds support for nullSafeAnnotations to java SpecificCompiler [avro]

2024-01-23 Thread via GitHub
opwvhk commented on PR #2142: URL: https://github.com/apache/avro/pull/2142#issuecomment-1906735079 @m-kay It will be in the next release, version 1.12.0. The most authoritative source on it is the dev mailing list. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] AVRO-3666 [Java] Use the new schema parser [avro]

2024-01-23 Thread via GitHub
opwvhk commented on code in PR #2642: URL: https://github.com/apache/avro/pull/2642#discussion_r1463526713 ## lang/java/avro/src/main/java/org/apache/avro/Schema.java: ## @@ -1867,47 +1781,70 @@ private static boolean isValidValue(Schema schema, JsonNode value) { } }

Re: [PR] AVRO-3666 [Java] Use the new schema parser [avro]

2024-01-23 Thread via GitHub
github-advanced-security[bot] commented on code in PR #2642: URL: https://github.com/apache/avro/pull/2642#discussion_r1463492814 ## lang/java/avro/src/main/java/org/apache/avro/Schema.java: ## @@ -1867,267 +1780,187 @@ } } - /** - * Parse named schema in order to

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
spektom commented on code in PR #843: URL: https://github.com/apache/avro/pull/843#discussion_r1462987952 ## lang/c/src/avro/logical.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
martin-g commented on code in PR #843: URL: https://github.com/apache/avro/pull/843#discussion_r1462978332 ## lang/c/src/avro/logical.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
spektom commented on code in PR #843: URL: https://github.com/apache/avro/pull/843#discussion_r1462969698 ## lang/c/src/avro/logical.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
martin-g commented on PR #843: URL: https://github.com/apache/avro/pull/843#issuecomment-1905630578 Since there is no active maintainer of the C SDK I'd propose that at least two users/contributors review, test and approve this PR! Then I could merge it for you! -- This is an

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
martin-g commented on code in PR #843: URL: https://github.com/apache/avro/pull/843#discussion_r1462950141 ## lang/c/src/avro/logical.h: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-01-23 Thread via GitHub
martin-g commented on PR #843: URL: https://github.com/apache/avro/pull/843#issuecomment-1905563563 I will close/reopen the PR to trigger the CI checks. But I have no experience with the C SDK to be able to review and merge it! -- This is an automated message from the Apache Git