Re: [PR] AVRO-3666 [Java] Use the new schema parser [avro]

2024-05-06 Thread via GitHub
g1rjeevan commented on PR #2642: URL: https://github.com/apache/avro/pull/2642#issuecomment-2097428004 @Fokko Any update on the release ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Comment Edited] (AVRO-2299) Get Plain Schema

2024-05-06 Thread Oscar Westra van Holthe - Kind (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843855#comment-17843855 ] Oscar Westra van Holthe - Kind edited comment on AVRO-2299 at 5/6/24 7:52 PM: --

[jira] [Commented] (AVRO-2299) Get Plain Schema

2024-05-06 Thread Oscar Westra van Holthe - Kind (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843855#comment-17843855 ] Oscar Westra van Holthe - Kind commented on AVRO-2299: -- Hi everyone,

[jira] [Commented] (AVRO-3677) Introduce Named Schema Formatters

2024-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843691#comment-17843691 ] ASF subversion and git services commented on AVRO-3677: --- Commit 362a

Re: [PR] AVRO-3677: Add SchemaFormatter [avro]

2024-05-06 Thread via GitHub
opwvhk commented on code in PR #2885: URL: https://github.com/apache/avro/pull/2885#discussion_r1590715165 ## lang/java/idl/src/main/java/org/apache/avro/util/IdlUtils.java: ## @@ -0,0 +1,541 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AVRO-3677: Add SchemaFormatter [avro]

2024-05-06 Thread via GitHub
Fokko commented on code in PR #2885: URL: https://github.com/apache/avro/pull/2885#discussion_r1590702527 ## lang/java/avro/src/main/java/org/apache/avro/JsonSchemaFormatterFactory.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] AVRO-3677: Add SchemaFormatter [avro]

2024-05-06 Thread via GitHub
opwvhk commented on code in PR #2885: URL: https://github.com/apache/avro/pull/2885#discussion_r1590691459 ## lang/java/avro/src/main/java/org/apache/avro/JsonSchemaFormatterFactory.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] AVRO-3677: Add SchemaFormatter [avro]

2024-05-06 Thread via GitHub
opwvhk commented on code in PR #2885: URL: https://github.com/apache/avro/pull/2885#discussion_r1590665091 ## lang/java/idl/src/main/java/org/apache/avro/idl/IdlSchemaParser.java: ## @@ -27,14 +27,17 @@ import java.util.regex.Pattern; public class IdlSchemaParser implements

Re: [PR] AVRO-3677: Add SchemaFormatter [avro]

2024-05-06 Thread via GitHub
opwvhk commented on code in PR #2885: URL: https://github.com/apache/avro/pull/2885#discussion_r1590663780 ## lang/java/idl/src/main/java/org/apache/avro/util/IdlUtils.java: ## @@ -0,0 +1,541 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] AVRO-2773: [C] Add decimal logical schema [avro]

2024-05-06 Thread via GitHub
SahilKang commented on PR #2891: URL: https://github.com/apache/avro/pull/2891#issuecomment-2095345444 this is an alternative to #843 where the decimal support is added to the value api instead of the deprecated datum api, and decimals are a "first class citizen" in that `AVRO_DECIMAL` exte

Re: [PR] [AVRO-2773] Added support for logical types in C [avro]

2024-05-06 Thread via GitHub
SahilKang commented on code in PR #843: URL: https://github.com/apache/avro/pull/843#discussion_r1590626595 ## lang/c/src/schema.h: ## @@ -76,12 +78,30 @@ struct avro_link_schema_t { avro_schema_t to; }; +struct avro_bytes_schema_t { + struct avro_obj_t obj; + avro_