jbonofre commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2098843291
@g1rjeevan I'm working on both 1.11.4 and 1.12.0 releases preparation. I
need to merge one pending change. I hope to submit the release to vote next
week.
--
This is an automated
g1rjeevan commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2097428004
@Fokko Any update on the release ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Fokko commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2047574517
A release is near, see the public mailing list:
https://lists.apache.org/thread/qg70g7d9j5odkf8fxnnm342mm2kj997l I would say
this month since the release process always takes some time in
g1rjeevan commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2047471513
Hi Team,
Did 1.12.0 or 1.11.4 got released ? I see CVEs fixes related
commons-compress 1.26.0 are already in place. Seems to be release is pending.
If not released, what would be
Fokko commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2036592931
Thanks for working on this @opwvhk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Fokko commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-2034587224
@opwvhk Could you resolve the merge conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fokko commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1549641360
##
lang/java/avro/src/main/java/org/apache/avro/ParseContext.java:
##
@@ -18,25 +18,36 @@
package org.apache.avro;
Review Comment:
This is a new file, so it is okay to
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1504415743
##
lang/java/avro/src/main/java/org/apache/avro/util/SchemaResolver.java:
##
@@ -111,67 +105,6 @@ public static boolean isFullyResolvedSchema(final Schema
schema) {
github-advanced-security[bot] commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1504196997
##
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SchemaTask.java:
##
@@ -17,20 +17,21 @@
*/
package
opwvhk commented on PR #2642:
URL: https://github.com/apache/avro/pull/2642#issuecomment-1943282582
> I tried to review this, but don't know where to start. The schema parser
is very fundamental and there are 150+ files to review. My biggest concern is
about breaking public API's. We had
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1489083861
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1546,26 +1461,13 @@ public Schema parse(File file) throws IOException {
return
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1489075983
##
lang/java/avro/src/main/java/org/apache/avro/util/SchemaResolver.java:
##
@@ -111,67 +105,6 @@ public static boolean isFullyResolvedSchema(final Schema
schema) {
Fokko commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1480403168
##
lang/java/avro/src/main/java/org/apache/avro/util/SchemaResolver.java:
##
@@ -111,67 +105,6 @@ public static boolean isFullyResolvedSchema(final Schema
schema) {
}
Fokko commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1480394485
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1546,26 +1461,13 @@ public Schema parse(File file) throws IOException {
return
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1463526713
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1867,47 +1781,70 @@ private static boolean isValidValue(Schema schema,
JsonNode value) {
}
}
github-advanced-security[bot] commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1463492814
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1867,267 +1780,187 @@
}
}
- /**
- * Parse named schema in order to
github-advanced-security[bot] commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1459347034
##
lang/java/compiler/src/test/java/org/apache/avro/compiler/schema/TestSchemas.java:
##
@@ -265,20 +267,21 @@
+ "{\"name\": \"f1\",
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1459290267
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1920,214 +1857,54 @@ static Schema parseNamesDeclared(JsonNode schema,
Names names, String currentNam
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1459282555
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -1867,47 +1781,70 @@ private static boolean isValidValue(Schema schema,
JsonNode value) {
}
}
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1459280310
##
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##
@@ -125,20 +125,20 @@ private Object readResolve() {
FACTORY.setCodec(MAPPER);
}
- /** The type
opwvhk commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1459258370
##
lang/java/avro/src/main/java/org/apache/avro/ParseContext.java:
##
@@ -220,6 +232,77 @@ public void rollback() {
newSchemas.clear();
}
+ /**
+ * Resolve
clesaec commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1432418183
##
lang/java/avro/src/main/java/org/apache/avro/ParseContext.java:
##
@@ -220,6 +232,77 @@ public void rollback() {
newSchemas.clear();
}
+ /**
+ * Resolve
github-advanced-security[bot] commented on code in PR #2642:
URL: https://github.com/apache/avro/pull/2642#discussion_r1431314277
##
lang/java/avro/src/main/java/org/apache/avro/JsonSchemaParser.java:
##
@@ -57,26 +57,34 @@
for (String fragment : fragments) {
23 matches
Mail list logo
