[ https://issues.apache.org/jira/browse/BEAM-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030963#comment-17030963 ]
Luke Cwik edited comment on BEAM-4150 at 2/5/20 9:02 PM: --------------------------------------------------------- I believe so with pr/10755, is there some additional clean-up that was missed? was (Author: lcwik): I believe so with pr/10755. > Standardize use of PCollection coder proto attribute > ---------------------------------------------------- > > Key: BEAM-4150 > URL: https://issues.apache.org/jira/browse/BEAM-4150 > Project: Beam > Issue Type: Task > Components: beam-model > Reporter: Robert Bradshaw > Assignee: Luke Cwik > Priority: Major > Fix For: 2.20.0 > > Time Spent: 5h > Remaining Estimate: 0h > > In some places it's expected to be a WindowedCoder, in others the raw > ElementCoder. We should use the same convention (decided in discussion to be > the raw ElementCoder) everywhere. The WindowCoder can be pulled out of the > attached windowing strategy, and the input/output ports should specify the > encoding directly rather than read the adjacent PCollection coder fields. -- This message was sent by Atlassian Jira (v8.3.4#803005)