[jira] [Commented] (BEAM-3580) Do not use Go BytesCoder to encode string

2019-01-18 Thread Robert Burke (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746571#comment-16746571 ] Robert Burke commented on BEAM-3580: There may be one or two no longer necessary []byt

[jira] [Commented] (BEAM-3580) Do not use Go BytesCoder to encode string

2019-01-15 Thread Tianyang Hu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743374#comment-16743374 ] Tianyang Hu commented on BEAM-3580: --- Sounds good. Sorry that I didn't get the time to fi

[jira] [Commented] (BEAM-3580) Do not use Go BytesCoder to encode string

2019-01-15 Thread Robert Burke (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743367#comment-16743367 ] Robert Burke commented on BEAM-3580: I'm in the process of fixing Top, and I ran into

[jira] [Commented] (BEAM-3580) Do not use Go BytesCoder to encode string

2019-01-04 Thread Robert Burke (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734374#comment-16734374 ] Robert Burke commented on BEAM-3580: You're right though, a dedicated custom coder for

[jira] [Commented] (BEAM-3580) Do not use Go BytesCoder to encode string

2019-01-03 Thread Tianyang Hu (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733743#comment-16733743 ] Tianyang Hu commented on BEAM-3580: --- Seems that this breaks beam.Combine(s, combineFn, P