[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17131385#comment-17131385
]
Beam JIRA Bot commented on BEAM-7049:
-
This issue was marked "stale-assigned" and has not received a
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17122065#comment-17122065
]
Kenneth Knowles commented on BEAM-7049:
---
This issue is assigned but has not received an update in 30
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946252#comment-16946252
]
sridhar Reddy commented on BEAM-7049:
-
Thank you for the update.
re: Infinite Loop. I encountered
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944063#comment-16944063
]
Rui Wang commented on BEAM-7049:
Ah ok. I found a tricky problem: given the merged cost based
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943253#comment-16943253
]
sridhar Reddy commented on BEAM-7049:
-
Sounds good. Take your time. I appreciate you helping people on
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16943072#comment-16943072
]
Rui Wang commented on BEAM-7049:
Sorry [~sridharG] I probably have missed your message and indeed we are
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941410#comment-16941410
]
sridhar Reddy commented on BEAM-7049:
-
[~amaliujia] I just want to make sure that we are on the same
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933828#comment-16933828
]
sridhar Reddy commented on BEAM-7049:
-
I reviewed the PR and related JIRA. I see what you are saying.
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933052#comment-16933052
]
Rui Wang commented on BEAM-7049:
Recently there was a effort to separate multiple join implementation from
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933048#comment-16933048
]
sridhar Reddy commented on BEAM-7049:
-
I agree with your assessment.
> Merge multiple input to one
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933047#comment-16933047
]
Rui Wang commented on BEAM-7049:
Hmm this JIRA becomes more complicated than I imagined.
So to conclude:
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933042#comment-16933042
]
sridhar Reddy commented on BEAM-7049:
-
[~amaliujia] I tried the tests you suggested and have noted the
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933041#comment-16933041
]
sridhar Reddy commented on BEAM-7049:
-
I did the tests with the following steps
# re-clone a new repo
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932032#comment-16932032
]
sridhar Reddy commented on BEAM-7049:
-
I noticed there is a change in behavior between union vs union
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929541#comment-16929541
]
sridhar Reddy commented on BEAM-7049:
-
I believe all the code that is required for this feature to
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929500#comment-16929500
]
sridhar Reddy commented on BEAM-7049:
-
With the change in location of UnionMergeRule.INSTANCE it is
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929477#comment-16929477
]
Rui Wang commented on BEAM-7049:
Interesting. I left a comment on your PR.
> Merge multiple input to one
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929478#comment-16929478
]
sridhar Reddy commented on BEAM-7049:
-
My WIP pull request (#9358 )already contains code to handle
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929474#comment-16929474
]
sridhar Reddy commented on BEAM-7049:
-
My inputs here are 2
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929466#comment-16929466
]
sridhar Reddy commented on BEAM-7049:
-
For the query "SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929007#comment-16929007
]
Rui Wang commented on BEAM-7049:
I can then observe that there are 5 inputs at here:
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928996#comment-16928996
]
Rui Wang commented on BEAM-7049:
I used query
"SELECT 1 UNION ALL SELECT 2 UNION ALL SELECT 3 UNION ALL
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928956#comment-16928956
]
sridhar Reddy commented on BEAM-7049:
-
Sounds good!
> Merge multiple input to one BeamUnionRel
>
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928954#comment-16928954
]
Rui Wang commented on BEAM-7049:
[~sridharG]
I will do some testing on my side to check UnionMergeRule
>
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921535#comment-16921535
]
sridhar Reddy commented on BEAM-7049:
-
Hope you had a nice vacation! I will be on vacation myself from
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921523#comment-16921523
]
Rui Wang commented on BEAM-7049:
Hello, I was on a vocation and I am catching up pending emails, etc. Will
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919139#comment-16919139
]
sridhar Reddy commented on BEAM-7049:
-
After several attempts to generalize union with multiple
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913442#comment-16913442
]
sridhar Reddy commented on BEAM-7049:
-
Thanks for the quick update. I agree that it is helpful to have
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912980#comment-16912980
]
Rui Wang commented on BEAM-7049:
Although usually most of the use case we might only need <5 UNIONs, it
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912882#comment-16912882
]
sridhar Reddy commented on BEAM-7049:
-
Just including UnionMergeRule.INSTANCE in BeamRuleSets makes
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908680#comment-16908680
]
sridhar Reddy commented on BEAM-7049:
-
Here is the pull request. As I mentioned in the description the
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907689#comment-16907689
]
sridhar Reddy commented on BEAM-7049:
-
Good idea! I will create one
> Merge multiple input to one
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906758#comment-16906758
]
Rui Wang commented on BEAM-7049:
[~sridharG]
I would also encourage you keep a WIP PR in
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906734#comment-16906734
]
sridhar Reddy commented on BEAM-7049:
-
Made a couple of simple cases work
1)select 1 from
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905707#comment-16905707
]
Rui Wang commented on BEAM-7049:
Sounds good! BTW you might need to enable [1] in [2]
[1]:
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905695#comment-16905695
]
sridhar Reddy commented on BEAM-7049:
-
Made great progress in understanding the code but still working
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903422#comment-16903422
]
sridhar Reddy commented on BEAM-7049:
-
[~amaliujia] Thanks for the update. I think I understand the
[
https://issues.apache.org/jira/browse/BEAM-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902560#comment-16902560
]
Rui Wang commented on BEAM-7049:
And actually I think this JIRA's title was misleading, multiple UNION
38 matches
Mail list logo
