[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

2018-03-07 Thread GitBox
ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-371106310 @reddycharan number of tasks should be fine. I'd just remove the timeout. Up to you though.

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

2018-03-06 Thread GitBox
ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370785040 > When time has elapsed, the pending tasks are cancelled. It seems it infact waited for 6

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

2018-03-06 Thread GitBox
ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370765608 ``` 2018-03-06 01:43:23,095 - INFO - [main:ScanAndCompareGarbageCollector@103] - Over

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

2018-03-06 Thread GitBox
ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370758791 @reddycharan test is failing. Saying that flush task was cancelled. I don't see how that can be