[jira] [Commented] (CALCITE-1947) Add time/timestamp with local time zone types to optimizer

2017-09-04 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153125#comment-16153125 ] Julian Hyde commented on CALCITE-1947: -- +1 when you've made the (mainly cosmetic) fixes below. I

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-04 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152922#comment-16152922 ] Christian Beikov commented on CALCITE-1940: --- No worries. I didn't bet on this getting into

[jira] [Commented] (CALCITE-1946) Dialects lacking support for nested aggregations should use sub select instead

2017-09-04 Thread Pawel Ruchaj (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152796#comment-16152796 ] Pawel Ruchaj commented on CALCITE-1946: --- I think we need a code which checks that: - current SQL

[jira] [Commented] (CALCITE-1947) Add time/timestamp with local time zone types to optimizer

2017-09-04 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152778#comment-16152778 ] Julian Hyde commented on CALCITE-1947: -- I will try to review this tonight so that it can get into