[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330166#comment-16330166 ] Michael Mior commented on CALCITE-2027: --- Looks like Travis is [failing to compile

[jira] [Commented] (CALCITE-2128) Add jethro sql dialect and jdbc support

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329879#comment-16329879 ] Julian Hyde commented on CALCITE-2128: -- A few new things: * No need to add a "Conne

[jira] [Resolved] (CALCITE-2107) Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2107. -- Resolution: Fixed Fix Version/s: 1.16.0 Fixed in [7f86f4e6|http://git-wip-us.apache.or

[jira] [Resolved] (CALCITE-2133) Allow SqlGroupedWindowFunction to specify returnTypeInference in its constructor

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2133. -- Resolution: Fixed Fixed in [522f6548|http://git-wip-us.apache.org/repos/asf/calcite/commit/52

[jira] [Commented] (CALCITE-2090) Extend Druid Range Rules to extract interval from Floor

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329862#comment-16329862 ] Julian Hyde commented on CALCITE-2090: -- A further commit [3e958cff|http://git-wip-

[jira] [Resolved] (CALCITE-1188) NullPointerException in EXTRACT with WHERE ... IN clause if field has null value

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-1188. -- Resolution: Fixed Fix Version/s: 1.16.0 Test case added in [8de5d8d0|http://git-wip-us

[jira] [Commented] (CALCITE-2088) More complex end2end tests in Calcite Plus module

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329703#comment-16329703 ] Julian Hyde commented on CALCITE-2088: -- Luis Rocha replied to the email thread and

[jira] [Commented] (CALCITE-2107) Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329641#comment-16329641 ] Julian Hyde commented on CALCITE-2107: -- More review: * {{Granularities.extractGranu

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329637#comment-16329637 ] Michael Mior commented on CALCITE-2027: --- Also done. I keep forgetting that Calcite

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329634#comment-16329634 ] Julian Hyde commented on CALCITE-2027: -- Thanks. Since there are no intervening comm

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329629#comment-16329629 ] Michael Mior commented on CALCITE-2027: --- Done. Committed the change again with thi

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329573#comment-16329573 ] Julian Hyde commented on CALCITE-2027: -- Java generics are missing contravariant typ

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329531#comment-16329531 ] Michael Mior commented on CALCITE-2027: --- I actually see the error under JDK 9 as w

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329517#comment-16329517 ] Julian Hyde commented on CALCITE-2027: -- I vaguely remember a discussion on the java

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329512#comment-16329512 ] Michael Mior commented on CALCITE-2027: --- Ack, it seems as though you're right. Sor

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329505#comment-16329505 ] Julian Hyde commented on CALCITE-2027: -- I'm using JDK 8 (1.8.0-b132 on macOS). Try

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Michael Mior (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329499#comment-16329499 ] Michael Mior commented on CALCITE-2027: --- Odd. What JDK version are you using? Thin

[jira] [Commented] (CALCITE-2027) Drop support for Java 7 (JDK 1.7)

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329485#comment-16329485 ] Julian Hyde commented on CALCITE-2027: -- [~michaelmior], I get an error {noformat}[E

[jira] [Updated] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2138: - Description: Add Locale.getDefault() to forbidden api list. Came as part of discussion in CALCI

[jira] [Updated] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2138: - Description: Came as part of discussion in https://issues.apache.org/jira/browse/CALCITE-2107.

[jira] [Updated] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2138: - Description: Add Locale.getDefault() to forbidden api list. Came as part of discussion in http

[jira] [Commented] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329437#comment-16329437 ] Julian Hyde commented on CALCITE-2138: -- We should ban TimeZone.getDefault() also.

[jira] [Updated] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2138: - Environment: (was: came as part of discussion in https://issues.apache.org/jira/browse/CALCI

[jira] [Resolved] (CALCITE-487) Update checkstyle to 6.1.1

2018-01-17 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-487. - Resolution: Duplicate Fix Version/s: 1.14.0 Marking duplicate because superseded by CALCIT

[jira] [Created] (CALCITE-2139) Upgrade checkstyle

2018-01-17 Thread Julian Hyde (JIRA)
Julian Hyde created CALCITE-2139: Summary: Upgrade checkstyle Key: CALCITE-2139 URL: https://issues.apache.org/jira/browse/CALCITE-2139 Project: Calcite Issue Type: Bug Environment:

[jira] [Commented] (CALCITE-2128) Add jethro sql dialect and jdbc support

2018-01-17 Thread Jonathan Doron (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328922#comment-16328922 ] Jonathan Doron commented on CALCITE-2128: - Yes, please review. > Add jethro sql

[jira] [Comment Edited] (CALCITE-2107) Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

2018-01-17 Thread Nishant Bangarwa (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328867#comment-16328867 ] Nishant Bangarwa edited comment on CALCITE-2107 at 1/17/18 3:18 PM: --

[jira] [Commented] (CALCITE-2107) Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

2018-01-17 Thread Nishant Bangarwa (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328867#comment-16328867 ] Nishant Bangarwa commented on CALCITE-2107: --- [~julianhyde] Update the PR based

[jira] [Created] (CALCITE-2138) Add Locale.getDefault() to forbidden api list

2018-01-17 Thread Nishant Bangarwa (JIRA)
Nishant Bangarwa created CALCITE-2138: - Summary: Add Locale.getDefault() to forbidden api list Key: CALCITE-2138 URL: https://issues.apache.org/jira/browse/CALCITE-2138 Project: Calcite I

[jira] [Commented] (CALCITE-2107) Timezone not passed as part of granularity when passing TimeExtractionFunction to Druid

2018-01-17 Thread Nishant Bangarwa (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328819#comment-16328819 ] Nishant Bangarwa commented on CALCITE-2107: --- [~jcamachorodriguez] [~julianhyde