[jira] [Commented] (CALCITE-2677) Struct types with one field are not mapped correctly to Java Classes

2018-12-03 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708268#comment-16708268 ] Stamatis Zampetakis commented on CALCITE-2677: -- I tried to illustrate the problem with a

[jira] [Commented] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-12-03 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708236#comment-16708236 ] Enrico Olivelli commented on CALCITE-2662: -- Thank you Julian and Vladmin for review   >

[jira] [Commented] (CALCITE-2468) Validator throws IndexOutOfBoundsException when trying to infer operand type from struct return type

2018-12-03 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708094#comment-16708094 ] Rong Rong commented on CALCITE-2468: Hi [~julianhyde], sorry I somehow missed the 2nd part of your

[jira] [Commented] (CALCITE-2658) Introducing more ReduceExpressionRules

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708091#comment-16708091 ] Julian Hyde commented on CALCITE-2658: -- Reviewing PR 912 WindowReduceExpressionsRule: * Can you

[jira] [Comment Edited] (CALCITE-2658) Introducing more ReduceExpressionRules

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708078#comment-16708078 ] Julian Hyde edited comment on CALCITE-2658 at 12/4/18 2:03 AM: --- Reviewing

[jira] [Commented] (CALCITE-2658) Introducing more ReduceExpressionRules

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708078#comment-16708078 ] Julian Hyde commented on CALCITE-2658: -- Reviewing PR 921 ExchangeRemoveConstantKeysRule: * You

[jira] [Commented] (CALCITE-2677) Struct types with one field are not mapped correctly to Java Classes

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708063#comment-16708063 ] Julian Hyde commented on CALCITE-2677: -- It depends on your definition of "correct". > Struct

[jira] [Commented] (CALCITE-2468) Validator throws IndexOutOfBoundsException when trying to infer operand type from struct return type

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708045#comment-16708045 ] Julian Hyde commented on CALCITE-2468: -- Did you try recursing? The code for AS still looks very

[jira] [Updated] (CALCITE-2719) MySQL does not support cast to BIGINT type

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-2719: - Summary: MySQL does not support cast to BIGINT type (was: MySQL does not support cast to

[jira] [Resolved] (CALCITE-2709) GeodeFilter Support for temporal types and searches (DATE, TIME, TIMESTAMP etc.)

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2709. -- Resolution: Fixed Fix Version/s: 1.18.0 Fixed in

[jira] [Comment Edited] (CALCITE-2619) Reduce string literal creation cost by removing unnecessary charset check

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706429#comment-16706429 ] Julian Hyde edited comment on CALCITE-2619 at 12/4/18 12:46 AM: Fixed

[jira] [Resolved] (CALCITE-2529) linq4j should promote integer to floating point when generating function calls

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2529. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2662) Planner: allow parsing directly a stream instead of a java.lang.String

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-2662. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708028#comment-16708028 ] Julian Hyde commented on CALCITE-2688: -- Fixed in

[jira] [Comment Edited] (CALCITE-2701) Ensure that the "Baz" classes generated by Janino are thread-safe

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706433#comment-16706433 ] Julian Hyde edited comment on CALCITE-2701 at 12/4/18 12:46 AM: Fixed

[jira] [Comment Edited] (CALCITE-2679) Group by without aggregation function cannot be translated to correct JSON in Elasticsearch Adapter

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706432#comment-16706432 ] Julian Hyde edited comment on CALCITE-2679 at 12/4/18 12:45 AM: Fixed

[jira] [Comment Edited] (CALCITE-2699) TIMESTAMPADD function handles TIME incorrectly

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706434#comment-16706434 ] Julian Hyde edited comment on CALCITE-2699 at 12/4/18 12:45 AM: Fixed

[jira] [Comment Edited] (CALCITE-2720) Presence of an empty aggregation should not lead to Exceptions

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706426#comment-16706426 ] Julian Hyde edited comment on CALCITE-2720 at 12/4/18 12:44 AM: Fixed

[jira] [Resolved] (CALCITE-2713) JDBC adapter may generate casts on PostgreSQL for VARCHAR type exceeding max length

2018-12-03 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez resolved CALCITE-2713. -- Resolution: Fixed [~julianhyde], I have merged it because I

[jira] [Commented] (CALCITE-2713) JDBC adapter may generate casts on PostgreSQL for VARCHAR type exceeding max length

2018-12-03 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707898#comment-16707898 ] Jesus Camacho Rodriguez commented on CALCITE-2713: -- [~julianhyde], I have updated the

[jira] [Commented] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707755#comment-16707755 ] Julian Hyde commented on CALCITE-2688: -- Ah, good catch. I screwed up the messages, and then,

[jira] [Commented] (CALCITE-2713) JDBC adapter may generate casts on PostgreSQL for VARCHAR type exceeding max length

2018-12-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707735#comment-16707735 ] Julian Hyde commented on CALCITE-2713: -- I'd like to do a force-push because I messed up the commit

[jira] [Commented] (CALCITE-2713) JDBC adapter may generate casts on PostgreSQL for VARCHAR type exceeding max length

2018-12-03 Thread Jesus Camacho Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707578#comment-16707578 ] Jesus Camacho Rodriguez commented on CALCITE-2713: -- Sure [~julianhyde], I will start

[jira] [Resolved] (CALCITE-2688) Improve diagnosability when return type could not be inferred.

2018-12-03 Thread Zoltan Haindrich (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich resolved CALCITE-2688. --- Resolution: Fixed Fix Version/s: 1.18.0 [~julianhyde]: This change seem to

[jira] [Commented] (CALCITE-2719) MySQL does not support cast to bigint type

2018-12-03 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706975#comment-16706975 ] Piotr Bojko commented on CALCITE-2719: -- I've pushed the suggested change for CAST to INTEGER >

[jira] [Commented] (CALCITE-2714) Make BasicSqlType immutable, and now createWithNullability re-uses existing type if possible

2018-12-03 Thread Ruben Quesada Lopez (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706955#comment-16706955 ] Ruben Quesada Lopez commented on CALCITE-2714: -- My pleasure, [~julianhyde]. Thanks for

[jira] [Commented] (CALCITE-2701) Ensure that the "Baz" classes generated by Janino are thread-safe

2018-12-03 Thread Stamatis Zampetakis (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706946#comment-16706946 ] Stamatis Zampetakis commented on CALCITE-2701: -- Thanks for the review and commit

[jira] [Created] (CALCITE-2722) SqlImplementor createLeftCall method throws StackOverflowError

2018-12-03 Thread Mykola Zerniuk (JIRA)
Mykola Zerniuk created CALCITE-2722: --- Summary: SqlImplementor createLeftCall method throws StackOverflowError Key: CALCITE-2722 URL: https://issues.apache.org/jira/browse/CALCITE-2722 Project:

[jira] [Comment Edited] (CALCITE-2719) MySQL does not support cast to bigint type

2018-12-03 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706859#comment-16706859 ] Piotr Bojko edited comment on CALCITE-2719 at 12/3/18 9:16 AM: ---

[jira] [Comment Edited] (CALCITE-2719) MySQL does not support cast to bigint type

2018-12-03 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706859#comment-16706859 ] Piotr Bojko edited comment on CALCITE-2719 at 12/3/18 9:16 AM: ---

[jira] [Commented] (CALCITE-2719) MySQL does not support cast to bigint type

2018-12-03 Thread Piotr Bojko (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706859#comment-16706859 ] Piotr Bojko commented on CALCITE-2719: -- [~julianhyde] I am afraid MySQL - as far I have read the