[jira] [Resolved] (CALCITE-3856) Remove code to be removed before 1.23

2020-03-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3856. - Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3855) Supports snapshot on table with virtual columns during sql-to-rel conversion

2020-03-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3855. - Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3724) Presto dialect implementation

2020-03-12 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058342#comment-17058342 ] Feng Zhu commented on CALCITE-3724: --- Hi [~x1q1j1], could please add some material (e.g., presto's

[jira] [Commented] (CALCITE-3679) Allow lambda expressions in SQL queries

2020-03-12 Thread Ritesh (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058123#comment-17058123 ] Ritesh commented on CALCITE-3679: - Thanks [~Chunwei Lei], For taking out time to review this PR :) >

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058120#comment-17058120 ] Julian Hyde commented on CALCITE-3815: -- If you can manage without adding a new SqlKind, do that.

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058112#comment-17058112 ] Julian Hyde commented on CALCITE-3851: -- 'set importance = 0' has always been a hack. Now we are

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058102#comment-17058102 ] Julian Hyde edited comment on CALCITE-3716 at 3/12/20, 5:06 PM:

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058102#comment-17058102 ] Julian Hyde commented on CALCITE-3716: -- [~zabetak] Yes. And add some comments explaining the

[jira] [Resolved] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L resolved CALCITE-3853. Resolution: Fixed > Minor improvements in SortJoinCopyRule >

[jira] [Commented] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057901#comment-17057901 ] Ruben Q L commented on CALCITE-3853: Fixed via

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3853: --- Description: A few improvements can be made on SortJoinCopyRule (introduced via CALCITE-2624): -

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3853: --- Priority: Trivial (was: Minor) > Minor improvements in SortJoinCopyRule >

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3853: --- Description: Several improvements can be made on SortJoinCopyRule (introduced via CALCITE-2624):

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3853: --- Fix Version/s: 1.23.0 > Minor improvements in SortJoinCopyRule >

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3853: Labels: pull-request-available (was: ) > Minor improvements in SortJoinCopyRule >

[jira] [Comment Edited] (CALCITE-3850) AssertionError when converts a SQL parse tree into a relational algebra expression

2020-03-12 Thread fa zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057770#comment-17057770 ] fa zheng edited comment on CALCITE-3850 at 3/12/20, 10:23 AM: -- Hi danny, I

[jira] [Comment Edited] (CALCITE-3850) AssertionError when converts a SQL parse tree into a relational algebra expression

2020-03-12 Thread fa zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057770#comment-17057770 ] fa zheng edited comment on CALCITE-3850 at 3/12/20, 10:20 AM: -- Hi danny, I

[jira] [Updated] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-12 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3853: --- Description: Several improvements can be made on SortJoinCopyRule (introduced via CALCITE-2624):

[jira] [Commented] (CALCITE-3850) AssertionError when converts a SQL parse tree into a relational algebra expression

2020-03-12 Thread fa zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057770#comment-17057770 ] fa zheng commented on CALCITE-3850: --- Hi danny, I find the problem, it can execute successfully with

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-03-12 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057758#comment-17057758 ] Stamatis Zampetakis commented on CALCITE-3716: -- [~julianhyde] I guess you mean in

[jira] [Updated] (CALCITE-3856) Remove code to be removed before 1.23

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3856: Labels: pull-request-available (was: ) > Remove code to be removed before 1.23 >

[jira] [Created] (CALCITE-3856) Remove code to be removed before 1.23

2020-03-12 Thread Danny Chen (Jira)
Danny Chen created CALCITE-3856: --- Summary: Remove code to be removed before 1.23 Key: CALCITE-3856 URL: https://issues.apache.org/jira/browse/CALCITE-3856 Project: Calcite Issue Type: Task

[jira] [Commented] (CALCITE-3850) AssertionError when converts a SQL parse tree into a relational algebra expression

2020-03-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057691#comment-17057691 ] Danny Chen commented on CALCITE-3850: - Calcite does not support IF function yet, the PR is in

[jira] [Updated] (CALCITE-3855) Supports snapshot on table with virtual columns during sql-to-rel conversion

2020-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3855: Labels: pull-request-available (was: ) > Supports snapshot on table with virtual

[jira] [Updated] (CALCITE-3855) Supports snapshot on table with virtual columns during sql-to-rel conversion

2020-03-12 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen updated CALCITE-3855: Description: In SqlToRelConverter#convertTemporalTable, we actually should not assume that the

[jira] [Created] (CALCITE-3855) Supports snapshot on table with virtual columns during sql-to-rel conversion

2020-03-12 Thread Danny Chen (Jira)
Danny Chen created CALCITE-3855: --- Summary: Supports snapshot on table with virtual columns during sql-to-rel conversion Key: CALCITE-3855 URL: https://issues.apache.org/jira/browse/CALCITE-3855

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057677#comment-17057677 ] Chunwei Lei commented on CALCITE-3852: -- Makes sense. I would update the pr. > RexSimplify doesn't

[jira] [Commented] (CALCITE-3850) AssertionError when converts a SQL parse tree into a relational algebra expression

2020-03-12 Thread fa zheng (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057659#comment-17057659 ] fa zheng commented on CALCITE-3850: --- Hi Danny, thanks for your attention, I try to run same sql with

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-12 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057637#comment-17057637 ] Zoltan Haindrich commented on CALCITE-3852: --- it would be better to rewrite it to {{AND(null,x