[jira] [Comment Edited] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei edited comment on CALCITE-3972 at 5/6/20, 5:19 AM: --- Add the

[jira] [Comment Edited] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei edited comment on CALCITE-3972 at 5/6/20, 5:19 AM: --- Add the

[jira] [Updated] (CALCITE-3963) Maintain logical properties at RelSet (equivalent group) instead of RelNode

2020-05-05 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai updated CALCITE-3963: - Summary: Maintain logical properties at RelSet (equivalent group) instead of RelNode (was:

[jira] [Commented] (CALCITE-3963) Maintains logical properties at RelSet (equivalent group) instead of RelNode

2020-05-05 Thread Jinpeng Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100463#comment-17100463 ] Jinpeng Wu commented on CALCITE-3963: - I think we all agree that RelNodes in a RelSet should share

[jira] [Commented] (CALCITE-3973) Writing SQL hints to a string results in SQL that cannot be parsed

2020-05-05 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100436#comment-17100436 ] Danny Chen commented on CALCITE-3973: - Thanks [~alexbaden] for reporting this ~ You are right, in

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100431#comment-17100431 ] Xiening Dai commented on CALCITE-2970: -- Also the RelBuilder is not immutable today. The stack can

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100427#comment-17100427 ] Xiening Dai commented on CALCITE-2970: -- {quote} It's not about the overhead of object creation.

[jira] [Commented] (CALCITE-3970) Table-valued function TUMBLE uses non-standard syntax

2020-05-05 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100402#comment-17100402 ] Danny Chen commented on CALCITE-3970: - [~amaliujia], previously we have supported a sub-query as

[jira] [Commented] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei commented on CALCITE-3972: -- Add the PR link:

[jira] [Created] (CALCITE-3973) Writing SQL hints to a string results in SQL that cannot be parsed

2020-05-05 Thread Alex Baden (Jira)
Alex Baden created CALCITE-3973: --- Summary: Writing SQL hints to a string results in SQL that cannot be parsed Key: CALCITE-3973 URL: https://issues.apache.org/jira/browse/CALCITE-3973 Project: Calcite

[jira] [Commented] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100341#comment-17100341 ] Haisheng Yuan commented on CALCITE-3972: [~julianhyde] [~zabetak] The new issue is here. >

[jira] [Commented] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100340#comment-17100340 ] Haisheng Yuan commented on CALCITE-3972: Spin out issue of CALCITE-2970. > Allow RelBuilder to

[jira] [Resolved] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2970. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Updated] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3972: --- Fix Version/s: 1.23.0 > Allow RelBuilder to create RelNode with convention and use it for

[jira] [Resolved] (CALCITE-3971) Support Calc in RelMdColumnOrigins

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3971. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3966) Trigger rules for existing RelSubset when it becomes delivered

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3966. Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3718) Support Intersect and Minus in Bindables

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3718. Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3969) Method RelTrait.apply(Mappings.Mapping) throws exception when mapping doesn't cover collation or distribution keys

2020-05-05 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100281#comment-17100281 ] Haisheng Yuan commented on CALCITE-3969: I don't think there is a need for

[jira] [Created] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Xiening Dai (Jira)
Xiening Dai created CALCITE-3972: Summary: Allow RelBuilder to create RelNode with convention and use it for trait convert Key: CALCITE-3972 URL: https://issues.apache.org/jira/browse/CALCITE-3972

[jira] [Assigned] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiening Dai reassigned CALCITE-3972: Assignee: Xiening Dai > Allow RelBuilder to create RelNode with convention and use it

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100255#comment-17100255 ] Julian Hyde commented on CALCITE-2970: -- It's not about the overhead of object creation. Adding a

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100223#comment-17100223 ] Xiening Dai commented on CALCITE-2970: -- It would have been easier if Java supports "const T &"

[jira] [Commented] (CALCITE-3969) Method RelTrait.apply(Mappings.Mapping) throws exception when mapping doesn't cover collation or distribution keys

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100211#comment-17100211 ] Julian Hyde commented on CALCITE-3969: -- The new 'if' in

[jira] [Commented] (CALCITE-3969) Method RelTrait.apply(Mappings.Mapping) throws exception when mapping doesn't cover collation or distribution keys

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100209#comment-17100209 ] Julian Hyde commented on CALCITE-3969: -- I see that you fixed some genuine bugs in Mappings, and

[jira] [Assigned] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-05-05 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L reassigned CALCITE-3926: -- Assignee: Ruben Q L > CannotPlanException when an empty LogicalValues requires a certain

[jira] [Updated] (CALCITE-3926) CannotPlanException when an empty LogicalValues requires a certain collation

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-3926: - Affects Version/s: (was: 1.23.0) 1.22.0 > CannotPlanException when

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099960#comment-17099960 ] Julian Hyde commented on CALCITE-2970: -- Use fromContext. Context is straightforward and

[jira] [Commented] (CALCITE-3970) Table-valued function TUMBLE uses non-standard syntax

2020-05-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099938#comment-17099938 ] Julian Hyde commented on CALCITE-3970: -- If it’s in the standard we should do it. But can you

[jira] [Commented] (CALCITE-3969) Method RelTrait.apply(Mappings.Mapping) throws exception when mapping doesn't cover collation or distribution keys

2020-05-05 Thread Roman Kondakov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099697#comment-17099697 ] Roman Kondakov commented on CALCITE-3969: - [~julianhyde], you are right. But this case is took

[jira] [Commented] (CALCITE-3951) Support different string comparison based on SqlCollation

2020-05-05 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099634#comment-17099634 ] Ruben Q L commented on CALCITE-3951: Thanks for you feedback [~zabetak]. bq. I am not sure if

[jira] [Commented] (CALCITE-3970) Table-valued function TUMBLE uses non-standard syntax

2020-05-05 Thread Viliam Durina (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099613#comment-17099613 ] Viliam Durina commented on CALCITE-3970: The standard has this syntax for passing tables as