[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125524#comment-17125524 ] Rui Wang commented on CALCITE-3737: --- [~danny0405] Viliam also brings some good points at

[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125522#comment-17125522 ] Rui Wang commented on CALCITE-3737: --- Another thought is for user-facing API, once it's decided, it's

[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125518#comment-17125518 ] Rui Wang commented on CALCITE-3737: --- Agreed move some of these discussion to a email thread. Thanks

[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125510#comment-17125510 ] Danny Chen commented on CALCITE-3737: - Thanks for the sharing, i think we need more discussion

[jira] [Commented] (CALCITE-4040) Nonstandard SqlAggFunction rollup NPE Exception

2020-06-03 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125489#comment-17125489 ] Feng Zhu commented on CALCITE-4040: --- Is this Exception only thrown in non-standard aggregation

[jira] [Commented] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125423#comment-17125423 ] Haisheng Yuan commented on CALCITE-4030: MaterializedViewRelOptRulesTest.

[jira] [Commented] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125421#comment-17125421 ] Rui Wang commented on CALCITE-4030: --- Nice! Thanks for your update! > Assert error during top-down

[jira] [Commented] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125418#comment-17125418 ] Haisheng Yuan commented on CALCITE-4030: The assertion error has been fixed in CALCITE-3981. >

[jira] [Resolved] (CALCITE-3991) The required boolean should always be provided in RelSet.getOrCreateSubset()

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3991. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in 

[jira] [Updated] (CALCITE-3991) The required boolean should always be provided in RelSet.getOrCreateSubset()

2020-06-03 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Botong Huang updated CALCITE-3991: -- Summary: The required boolean should always be provided in RelSet.getOrCreateSubset() (was:

[jira] [Commented] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-06-03 Thread Botong Huang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125322#comment-17125322 ] Botong Huang commented on CALCITE-3981: --- Thanks [~julianhyde] and [~hyuan] for the review! >

[jira] [Resolved] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3981. Resolution: Fixed Fixed in 

[jira] [Comment Edited] (CALCITE-4039) Missing LATERAL keyword after sql validate

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125253#comment-17125253 ] Rui Wang edited comment on CALCITE-4039 at 6/3/20, 7:30 PM: Will it it

[jira] [Commented] (CALCITE-4039) Missing LATERAL keyword after sql validate

2020-06-03 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125253#comment-17125253 ] Rui Wang commented on CALCITE-4039: --- Will it it helpful to 1. still goes through the validation. 2.

[jira] [Commented] (CALCITE-4036) Allow applying SemiJoinRule to join without aggregate below

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125227#comment-17125227 ] Haisheng Yuan commented on CALCITE-4036: More importantly, AggregateRemoveRule won't be

[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Viliam Durina (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125062#comment-17125062 ] Viliam Durina commented on CALCITE-3737: What's the other way? It's not in SQL standard. A

[jira] [Commented] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125013#comment-17125013 ] Haisheng Yuan commented on CALCITE-4032: Cool, thanks for the update, [~rubenql]. > Mark

[jira] [Commented] (CALCITE-4039) Missing LATERAL keyword after sql validate

2020-06-03 Thread YufeiLiu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124945#comment-17124945 ] YufeiLiu commented on CALCITE-4039: --- [~danny0405] I want to build a sql format tool of our internal

[jira] [Commented] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-06-03 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124944#comment-17124944 ] Ruben Q L commented on CALCITE-4032: No problem [~hyuan]. FYI, I updated my downstream project to

[jira] [Commented] (CALCITE-4039) Missing LATERAL keyword after sql validate

2020-06-03 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124831#comment-17124831 ] Danny Chen commented on CALCITE-4039: - Hi, [~liuyufei], it there any special reason why you need to

[jira] [Created] (CALCITE-4040) Nonstandard SqlAggFunction rollup NPE Exception

2020-06-03 Thread xzh_dz (Jira)
xzh_dz created CALCITE-4040: --- Summary: Nonstandard SqlAggFunction rollup NPE Exception Key: CALCITE-4040 URL: https://issues.apache.org/jira/browse/CALCITE-4040 Project: Calcite Issue Type: Wish

[jira] [Commented] (CALCITE-3737) HOP Table-valued Function

2020-06-03 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124812#comment-17124812 ] Danny Chen commented on CALCITE-3737: - [~vilo] thanks for reporting this, bq. but actually it is

[jira] [Commented] (CALCITE-4039) Missing LATERAL keyword after sql validate

2020-06-03 Thread TANG Wen-hui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124698#comment-17124698 ] TANG Wen-hui commented on CALCITE-4039: --- Calcite validate phase does not miss LATERAL operator,