[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133914#comment-17133914 ] Danny Chen commented on CALCITE-3786: - [~vladimirsitnikov] Thanks for the background sharing, if we

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133877#comment-17133877 ] Danny Chen commented on CALCITE-4059: - Thanks [~Aron.tao], did you try

[jira] [Updated] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4060: Description: Current TypeCoercionImpl#inOperationCoercion only considers IN.

[jira] [Updated] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4060: Description: current  !image-2020-06-12-10-43-52-584.png! >

[jira] [Updated] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4060: Attachment: image-2020-06-12-10-43-52-584.png > TypeCoercionImpl#inOperationCoercion doesn't

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133853#comment-17133853 ] Jiatao Tao commented on CALCITE-4060: - [~amaliujia] I add a ut:

[jira] [Comment Edited] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133846#comment-17133846 ] Jiatao Tao edited comment on CALCITE-4060 at 6/12/20, 2:23 AM: --- Hi

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133846#comment-17133846 ] Jiatao Tao commented on CALCITE-4060: - Hi [~julianhyde], I add a ut, and debug we can find the op

[jira] [Updated] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4060: Attachment: image-2020-06-12-10-22-49-218.png > TypeCoercionImpl#inOperationCoercion doesn't

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133842#comment-17133842 ] Jiatao Tao commented on CALCITE-4059: - [~amaliujia]  > SqlTypeUtil#equalSansNullability doesn't

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133799#comment-17133799 ] Haisheng Yuan commented on CALCITE-3786: {quote} Even we are with these additional object

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133771#comment-17133771 ] Julian Hyde commented on CALCITE-4060: -- I don't think NOT_IN should exist inside RexNodes. See

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133763#comment-17133763 ] Rui Wang commented on CALCITE-4060: --- [~Aron.tao] Could you use some examples in this Jira to

[jira] [Comment Edited] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133759#comment-17133759 ] Rui Wang edited comment on CALCITE-4059 at 6/11/20, 10:36 PM: -- [~Aron.tao]

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133759#comment-17133759 ] Rui Wang commented on CALCITE-4059: --- [~Aron.tao] could you improve this bug by adding some examples

[jira] [Resolved] (CALCITE-4038) Refactor RexVisitor, RexBiVisitor, RelOptUtil.InputFinder

2020-06-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-4038. -- Fix Version/s: 1.24.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-3975) Add options to ProjectFilterTransposeRule to push down project and filter expressions whole, not just field references

2020-06-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-3975. -- Fix Version/s: 1.24.0 Resolution: Fixed Fixed in

[jira] [Created] (CALCITE-4061) Build should fail if Calcite code uses deprecated APIs

2020-06-11 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-4061: Summary: Build should fail if Calcite code uses deprecated APIs Key: CALCITE-4061 URL: https://issues.apache.org/jira/browse/CALCITE-4061 Project: Calcite

[jira] [Assigned] (CALCITE-4061) Build should fail if Calcite code uses deprecated APIs

2020-06-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-4061: Assignee: Vladimir Sitnikov > Build should fail if Calcite code uses deprecated APIs >

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133280#comment-17133280 ] Jiatao Tao commented on CALCITE-4060: - MR: [https://github.com/apache/calcite/pull/2020] >

[jira] [Created] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-11 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4060: --- Summary: TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN. Key: CALCITE-4060 URL: https://issues.apache.org/jira/browse/CALCITE-4060 Project: Calcite

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133249#comment-17133249 ] Haisheng Yuan commented on CALCITE-4058: You mean objections? I would love to hear. > Add

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133247#comment-17133247 ] Jiatao Tao commented on CALCITE-4059: - Origin SqlTypeUtil#equalSansNullability only consider atomic

[jira] [Updated] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao updated CALCITE-4059: Summary: SqlTypeUtil#equalSansNullability doesn't consider Array/Map (was: equalSansNullability

[jira] [Created] (CALCITE-4059) equalSansNullability doesn't consider Array/Map

2020-06-11 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4059: --- Summary: equalSansNullability doesn't consider Array/Map Key: CALCITE-4059 URL: https://issues.apache.org/jira/browse/CALCITE-4059 Project: Calcite Issue

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133205#comment-17133205 ] Vladimir Sitnikov commented on CALCITE-3786: >so that we can finally compare 2 RexCall

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133190#comment-17133190 ] Danny Chen commented on CALCITE-3786: - [~vladimirsitnikov] I tried to normalize the RexCall in its

[jira] [Commented] (CALCITE-4055) RelFieldTrimmer loses hints

2020-06-11 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133011#comment-17133011 ] Ruben Q L commented on CALCITE-4055: [~danny0405] thanks for the info, I have tried to apply the

[jira] [Resolved] (CALCITE-3724) Presto dialect implementation

2020-06-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3724. - Fix Version/s: 1.24.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-4055) RelFieldTrimmer loses hints

2020-06-11 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-4055: --- Summary: RelFieldTrimmer loses hints (was: RelFieldTrimmer loses join hints) > RelFieldTrimmer

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-11 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132978#comment-17132978 ] Rui Wang commented on CALCITE-4058: --- I would guess people will have lots of opinions on this idea :)

[jira] [Resolved] (CALCITE-4053) RexSimplify should not pass exprs containing non-const subExprs to RexExecutor

2020-06-11 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-4053. - Resolution: Fixed Fixed in