[jira] [Updated] (CALCITE-4033) Unparser should not apply parentheses for UNNEST (as a built-in table operator)

2020-06-15 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Wang updated CALCITE-4033: -- Summary: Unparser should not apply parentheses for UNNEST (as a built-in table operator) (was:

[jira] [Updated] (CALCITE-4033) SqlNode.toSqlString paren

2020-06-15 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Wang updated CALCITE-4033: -- Summary: SqlNode.toSqlString paren (was: SqlNode.toSqlString generates wrong query for syntax

[jira] [Commented] (CALCITE-4033) SqlNode.toSqlString generates wrong query for syntax "literal(select * from unnest(...))"

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136325#comment-17136325 ] Julian Hyde commented on CALCITE-4033: -- The subject still says 'literal'; I think you mean

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136290#comment-17136290 ] Julian Hyde commented on CALCITE-3786: -- I agree with [~laurent]. It doesn't look as if we've

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136282#comment-17136282 ] Laurent Goujon commented on CALCITE-3786: - I'm not sure I understand why the change has been

[jira] [Reopened] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Laurent Goujon (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laurent Goujon reopened CALCITE-3786: - > Add Digest interface to enable efficient hashCode(equals) for RexNode and > RelNode >

[jira] [Commented] (CALCITE-4059) SqlTypeUtil#equalSansNullability doesn't consider Array/Map

2020-06-15 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136262#comment-17136262 ] Jiatao Tao commented on CALCITE-4059: - Hi [~danny0405], Could you possibly review this pr?

[jira] [Resolved] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-15 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved CALCITE-3786. - Fix Version/s: 1.24.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

2020-06-15 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136247#comment-17136247 ] Jiatao Tao commented on CALCITE-4060: - Hi [~julianhyde] , you can take a look at

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136230#comment-17136230 ] Julian Hyde commented on CALCITE-4058: -- bq. Why do we have EnumerableLimit? Because it's an

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136184#comment-17136184 ] Haisheng Yuan commented on CALCITE-4058: Hi [~julianhyde], thanks for commenting. {quote} So

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136139#comment-17136139 ] Julian Hyde commented on CALCITE-4027: -- Reviewing the PR: * Isn't there logic elsewhere to derive

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136134#comment-17136134 ] Julian Hyde commented on CALCITE-4058: -- Let's suppose we were to introduce a logical {{Limit}}

[jira] [Updated] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slim Bouguerra updated CALCITE-4065: Description: Calcite Row operator does not support the projection of a Nested row. Take

[jira] [Updated] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slim Bouguerra updated CALCITE-4065: Description: Calcite Row operator does not support the projection of a Nested row. Take

[jira] [Commented] (CALCITE-4064) Unnest on array with nested structs causes ArrayStoreException

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136122#comment-17136122 ] Julian Hyde commented on CALCITE-4064: -- I'm not sure. I think we want all objects (scalar values

[jira] [Commented] (CALCITE-4049) Reduce the time complexity of getting shortest distances

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136119#comment-17136119 ] Julian Hyde commented on CALCITE-4049: -- [~fan_li_ya], Can you describe the use case where you were

[jira] [Updated] (CALCITE-4033) SqlNode.toSqlString generates wrong query for syntax "literal(select * from unnest(...))"

2020-06-15 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Wang updated CALCITE-4033: -- Fix Version/s: 1.24.0 > SqlNode.toSqlString generates wrong query for syntax "literal(select * from

[jira] [Updated] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slim Bouguerra updated CALCITE-4065: Component/s: core > Projecting a nested Row fails with >

[jira] [Updated] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slim Bouguerra updated CALCITE-4065: Environment: (was: {code:java} // code placeholder {code}) > Projecting a nested Row

[jira] [Updated] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slim Bouguerra updated CALCITE-4065: Affects Version/s: 1.22.0 > Projecting a nested Row fails with >

[jira] [Created] (CALCITE-4065) Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement

2020-06-15 Thread Slim Bouguerra (Jira)
Slim Bouguerra created CALCITE-4065: --- Summary: Projecting a nested Row fails with org.apache.calcite.util.Util.needToImplement Key: CALCITE-4065 URL: https://issues.apache.org/jira/browse/CALCITE-4065

[jira] [Commented] (CALCITE-4049) Reduce the time complexity of getting shortest distances

2020-06-15 Thread Xiening Dai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135989#comment-17135989 ] Xiening Dai commented on CALCITE-4049: -- My point is we don't even need shortest path. For

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135879#comment-17135879 ] Ruben Q L commented on CALCITE-4058: I agree 100% with your comment [~hyuan]. > Add Limit and

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135874#comment-17135874 ] Haisheng Yuan commented on CALCITE-4058: [~rubenql] I totally understand you concern. Storing

[jira] [Comment Edited] (CALCITE-4049) Reduce the time complexity of getting shortest distances

2020-06-15 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135665#comment-17135665 ] Liya Fan edited comment on CALCITE-4049 at 6/15/20, 12:20 PM: -- Hi all,

[jira] [Commented] (CALCITE-3929) NullPointerException when deserialize UDAF aggregate call from json string

2020-06-15 Thread xzh_dz (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135774#comment-17135774 ] xzh_dz commented on CALCITE-3929: - [~yanlin-Lynn] [~wojustme]  Please help review this pr, when you

[jira] [Comment Edited] (CALCITE-4064) Unnest on array with nested structs causes ArrayStoreException

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135713#comment-17135713 ] Ruben Q L edited comment on CALCITE-4064 at 6/15/20, 10:15 AM: ---

[jira] [Commented] (CALCITE-4064) Unnest on array with nested structs causes ArrayStoreException

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135713#comment-17135713 ] Ruben Q L commented on CALCITE-4064: [~julianhyde], I am trying to work on a solution for this

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135686#comment-17135686 ] Ruben Q L commented on CALCITE-4058: Intuitively, it seems a good idea, but it would be a breaking

[jira] [Commented] (CALCITE-4049) Reduce the time complexity of getting shortest distances

2020-06-15 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135665#comment-17135665 ] Liya Fan commented on CALCITE-4049: --- Hi all, thank you for the fruitful discussion. I think we all

[jira] [Updated] (CALCITE-4026) CassandraFilter has generated wrong condition expression for filter with non string literal

2020-06-15 Thread TANG Wen-hui (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TANG Wen-hui updated CALCITE-4026: -- Summary: CassandraFilter has generated wrong condition expression for filter with non string

[jira] [Commented] (CALCITE-4049) Reduce the time complexity of getting shortest distances

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135590#comment-17135590 ] Ruben Q L commented on CALCITE-4049: Thanks for your input. I'd suggest then: - Revert the current

[jira] [Commented] (CALCITE-4064) Unnest on array with nested structs causes ArrayStoreException

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135546#comment-17135546 ] Ruben Q L commented on CALCITE-4064: Root cause is in

[jira] [Comment Edited] (CALCITE-4064) Unnest on array with nested structs causes ArrayStoreException

2020-06-15 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135546#comment-17135546 ] Ruben Q L edited comment on CALCITE-4064 at 6/15/20, 7:42 AM: -- Root cause